Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove previewnet #74

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Remove previewnet #74

merged 2 commits into from
Sep 5, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Sep 5, 2024

Closes #73

Copy link
Member

@nvdtf nvdtf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might wanna look into failing tests before merge

@jribbink jribbink merged commit 5ab7a1e into main Sep 5, 2024
2 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.82%. Comparing base (f6ec637) to head (c89f2a4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   43.80%   43.82%   +0.01%     
==========================================
  Files          40       40              
  Lines        3367     3366       -1     
==========================================
  Hits         1475     1475              
+ Misses       1632     1631       -1     
  Partials      260      260              
Flag Coverage Δ
unittests 43.82% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove previewnet
3 participants