Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove emulator #466

Merged
merged 24 commits into from
Nov 15, 2023
Merged

Remove emulator #466

merged 24 commits into from
Nov 15, 2023

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Nov 2, 2023 •
edited
Loading

Closes #467
Closes #465
Closes #313
Closes #347
Closes #176

Description

Removes emulator connection & associated tools

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink changed the title [WIP] Remove emulator [BLOCKED] Remove emulator Nov 7, 2023
@jribbink jribbink changed the title [BLOCKED] Remove emulator Remove emulator Nov 8, 2023
@jribbink jribbink marked this pull request as ready for review November 13, 2023 16:55
@jribbink jribbink requested a review from nialexsan November 13, 2023 16:56
@jribbink jribbink force-pushed the jribbink/remove-emulator branch 2 times, most recently from a93957d to f0253d5 Compare November 15, 2023 17:25
@jribbink jribbink force-pushed the jribbink/remove-emulator branch from 5d3352b to 8d4756b Compare November 15, 2023 17:35
@jribbink jribbink mentioned this pull request Nov 15, 2023
Closed
nialexsan
nialexsan reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@nialexsan nialexsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits

nialexsan
nialexsan approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@nialexsan nialexsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jribbink jribbink merged commit 66e5723 into master Nov 15, 2023
@jribbink jribbink deleted the jribbink/remove-emulator branch November 15, 2023 23:55
This was referenced Nov 16, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nialexsan nialexsan nialexsan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jribbink @nialexsan