Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce level_cmp option; :exact means exact level match #84

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,11 @@ multiple log files.

* `path` - the path to the log file
* `level` - the logging level for the backend
* `level_cmp` - `nil` (default): treat level as the _minimum_ logging level for the backend; `:exact` treat level as the _exact_ logging level for the backend
* `format` - the logging format for the backend
* `metadata` - the metadata to include
* `metadata_filter` - metadata terms which must be present in order to log
* metadata_reject - metadata terms which must be present in order to do not log
* `metadata_reject` - metadata terms which must be present in order to do not log

### Examples

Expand Down
15 changes: 13 additions & 2 deletions lib/logger_file_backend.ex
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,14 @@ defmodule LoggerFileBackend do

def handle_event(
{level, _gl, {Logger, msg, ts, md}},
%{level: min_level, metadata_filter: metadata_filter, metadata_reject: metadata_reject} =
%{level: min_level, level_cmp: level_cmp, metadata_filter: metadata_filter, metadata_reject: metadata_reject} =
state
) do
if (is_nil(min_level) or Logger.compare_levels(level, min_level) != :lt) and
level = case level do
:warn -> :warning
_ -> level
end
if level_matches?(level, min_level, level_cmp) and
metadata_matches?(md, metadata_filter) and
(is_nil(metadata_reject) or !metadata_matches?(md, metadata_reject)) do
log_event(level, msg, ts, md, state)
Expand Down Expand Up @@ -149,6 +153,10 @@ defmodule LoggerFileBackend do
Logger.Formatter.format(format, level, msg, ts, take_metadata(md, keys))
end

defp level_matches?(_, nil, _), do: true
defp level_matches?(level, min_level, nil), do: Logger.compare_levels(level, min_level) != :lt
defp level_matches?(level, min_level, :exact), do: Logger.compare_levels(level, min_level) == :eq

@doc false
@spec metadata_matches?(Keyword.t(), nil | Keyword.t()) :: true | false
def metadata_matches?(_md, nil), do: true
Expand Down Expand Up @@ -206,6 +214,7 @@ defmodule LoggerFileBackend do
inode: nil,
format: nil,
level: nil,
level_cmp: nil,
metadata: nil,
metadata_filter: nil,
metadata_reject: nil,
Expand All @@ -221,6 +230,7 @@ defmodule LoggerFileBackend do
Application.put_env(:logger, name, opts)

level = Keyword.get(opts, :level)
level_cmp = Keyword.get(opts, :level_cmp)
metadata = Keyword.get(opts, :metadata, [])
format_opts = Keyword.get(opts, :format, @default_format)
format = Logger.Formatter.compile(format_opts)
Expand All @@ -235,6 +245,7 @@ defmodule LoggerFileBackend do
path: path,
format: format,
level: level,
level_cmp: level_cmp,
metadata: metadata,
metadata_filter: metadata_filter,
metadata_reject: metadata_reject,
Expand Down