Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AutocompleteDropdownContext.tsx #141

Closed
wants to merge 1 commit into from

Conversation

AlexCernik
Copy link

fix headerOffset for suggestion list

fix headerOffset for suggestion list
@onmotion
Copy link
Owner

onmotion commented Oct 20, 2024

Do you have any scenario of how to reproduce the misbehavior?

@AlexCernik
Copy link
Author

@onmotion Hi, initialValue not work if remotedataset are empty or wait typing

@onmotion
Copy link
Owner

@AlexCernik sorry I didn't quite get how this related to the offset value

@AlexCernik
Copy link
Author

@AlexCernik sorry I didn't quite get how this related to the offset value

Sorry, in android suggestion list it appears too low.
And I found the problem that if initialValue is indicated and I haven't loaded the dataset yet, initialValue isn't displayed.

@onmotion
Copy link
Owner

Sorry, in android suggestion list it appears too low

Is it related to the notched device or any? A screenshot maybe? You can use an expo snack from the readme

initialValue is indicated and I haven't loaded the dataset yet

As the initialValue is chosen from a set of possible values, it should be a part of the dataset

@AlexCernik
Copy link
Author

@onmotion see #135. I think the ideal thing is to save initialValue regardless of whether the dataSet exists, since it must be written to perform the search and obtain that data.

@AlexCernik AlexCernik closed this by deleting the head repository Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants