Merge pull request #11 from onna/page-args

Support passing query params to iterate_bucket_page
onna · May 16, 2023 · 384515c · 384515c
2 parents fed1f60 + b4ce5b7
commit 384515c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -1,3 +1,7 @@
+6.0.8 (unreleased)
+------------------
+- Support arbitrary args to iterate bucket page method, e.g. to include deleted versions.
+
 6.0.7 (unreleased)
 ------------------
 - Method for generating signed download URLs

diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-6.0.7
+6.0.8
diff --git a/guillotina_gcloudstorage/storage.py b/guillotina_gcloudstorage/storage.py
@@ -569,11 +569,11 @@ async def iterate_bucket(self):
                 yield item
             page_token = data.get("nextPageToken")
 
-    async def iterate_bucket_page(self, page_token=None, prefix=None):
+    async def iterate_bucket_page(self, page_token=None, prefix=None, **params):
         url = "{}/{}/o".format(OBJECT_BASE_URL, await self.get_bucket_name())
         container = task_vars.container.get()
         prefix = prefix or container.id + "/"
-        params = {"prefix": prefix}
+        params.update({"prefix": prefix})
         if page_token:
             params["pageToken"] = page_token