Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to turbo and pnpm #1

Merged
merged 35 commits into from
Oct 30, 2024
Merged

Migrate to turbo and pnpm #1

merged 35 commits into from
Oct 30, 2024

Conversation

onnimonni
Copy link
Owner

We are using such an old version of Lerna that just building this package from the master branch is getting very tough.

I based this PR on top of: NotionX#461.

When running turbo build I did get an error from one of the examples and thus needed to install the prismjs to the full example:

notion-x-example-full:build: Failed to compile.
notion-x-example-full:build:
notion-x-example-full:build: ./components/NotionPage.tsx:23:14
notion-x-example-full:build: Type error: Cannot find module 'prismjs/components/prism-markup-templating.js' or its corresponding type declarations.
notion-x-example-full:build:
notion-x-example-full:build:   21 |     // additional prism syntaxes
notion-x-example-full:build:   22 |     await Promise.all([
notion-x-example-full:build: > 23 |       import('prismjs/components/prism-markup-templating.js'),
notion-x-example-full:build:      |              ^
notion-x-example-full:build:   24 |       import('prismjs/components/prism-markup.js'),
notion-x-example-full:build:   25 |       import('prismjs/components/prism-bash.js'),
notion-x-example-full:build:   26 |       import('prismjs/components/prism-c.js'),
notion-x-example-full:build:  ELIFECYCLE  Command failed with exit code 1.
notion-x-example-full:build: ERROR: command finished with error: command (/Users/onnimonni/Projects/react-notion-x/examples/full) pnpm run build exited (1)

@onnimonni onnimonni merged commit 479e73e into master Oct 30, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants