Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onnx wheel, experimental support for 3.13t (free threading) #6621

Open
wants to merge 83 commits into
base: main
Choose a base branch
from
Open

onnx wheel, experimental support for 3.13t (free threading) #6621

wants to merge 83 commits into from

Conversation

andife
Copy link
Member

@andife andife commented Jan 5, 2025 •
edited
Loading

Description

First try python 3.13t

main
[ ] Win
[X] linux aarch
[X] linux x
[X] mac

release_pipelines
[X] mac wheel compiles

@andife andife requested a review from a team as a code owner January 5, 2025 09:06
@codecov Codecov
Copy link

codecov bot commented Jan 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.45%. Comparing base (b3e627c) to head (cc9b812).

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6621   +/-   ##
=======================================
  Coverage   56.45%   56.45%           
=======================================
  Files         509      509           
  Lines       32515    32515           
  Branches     3057     3057           
=======================================
  Hits        18356    18356           
  Misses      13334    13334           
  Partials      825      825

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andife andife temporarily deployed to testpypi_onnxweekly January 5, 2025 10:24 — with GitHub Actions Inactive
@andife andife mentioned this pull request Jan 5, 2025
Open
@andife
Copy link
Member Author

andife commented Jan 5, 2025

We probably have to wait for python-cffi/cffi#126

@andife andife added the run release CIs Use this label to trigger release tests in CI label Jan 5, 2025
@andife andife temporarily deployed to testpypi_onnxweekly January 5, 2025 14:20 — with GitHub Actions Inactive
@andife andife changed the title Update main.yml First try python 3.13t First try python 3.13t Jan 6, 2025
@justinchuby
Copy link
Contributor

Looks promising!

@justinchuby
Copy link
Contributor

I will create a PR to fix the tests

@justinchuby justinchuby mentioned this pull request Jan 8, 2025
Merged
@justinchuby
Copy link
Contributor

#6631

@justinchuby justinchuby added this to the 1.18 milestone Jan 8, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 10, 2025
@justinchuby
Remove struct and leverage ml_dtypes in helper tests (#6631)
621e0d0 
Remove the use of struct and leverage ml_dtypes to clean up helper
tests. This should unblock #6621

---------

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby
Copy link
Contributor

Looks like the error is actually in from array

@justinchuby
Copy link
Contributor

#6604

@justinchuby
Copy link
Contributor

Test errors are resolved

@andife andife changed the title First try python 3.13t onnx wheel, 3.13t (free threading) Jan 16, 2025
@andife andife modified the milestones: 1.18, 1.19 Jan 18, 2025
@andife
Copy link
Member Author

andife commented Jan 23, 2025

We can currently also say that we are only integrating the mac build into our regular repo for the time being and can thus make the mac 3.13t build available on a weekly basis

@justinchuby

@justinchuby
Copy link
Contributor

Sure that works. Is using the workflow from quantsightlabs a viable solution from a supply chain perspective?

@justinchuby
Copy link
Contributor

Maybe we can use it only for 3.13t for now.

@andife andife changed the title onnx wheel, 3.13t (free threading) onnx wheel, experimental support for 3.13t (free threading) Jan 25, 2025
@andife andife added run release CIs Use this label to trigger release tests in CI and removed run release CIs Use this label to trigger release tests in CI labels Jan 25, 2025
@andife
Update release_linux_x86_64_freethreading.yml
37a0fdf 
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
@andife andife added run release CIs Use this label to trigger release tests in CI and removed run release CIs Use this label to trigger release tests in CI labels Feb 9, 2025
@andife andife added run release CIs Use this label to trigger release tests in CI and removed run release CIs Use this label to trigger release tests in CI labels Feb 9, 2025
seungwoo-ji-03 pushed a commit to seungwoo-ji-03/onnx that referenced this pull request Feb 17, 2025
@justinchuby @seungwoo-ji-03
Remove struct and leverage ml_dtypes in helper tests (onnx#6631)
a59a8ca 
Remove the use of struct and leverage ml_dtypes to clean up helper
tests. This should unblock onnx#6621

---------

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: seungwoo-ji <seungwoo.ji@nuvilab.com>
@justinchuby
Copy link
Contributor

Do you intend to merge this PR?

@andife
Copy link
Member Author

andife commented Feb 18, 2025

Do you intend to merge this PR?

no, not this one. But this: #6706

My plan is only to include the working parts of that PR. So depending on the release roadmap timeline for 1.18, we could think about a 3.13t wheel for mac

@andife andife added run release CIs Use this label to trigger release tests in CI and removed run release CIs Use this label to trigger release tests in CI labels Feb 18, 2025
@andife andife added run release CIs Use this label to trigger release tests in CI and removed run release CIs Use this label to trigger release tests in CI labels Feb 21, 2025
@andife andife added run release CIs Use this label to trigger release tests in CI and removed run release CIs Use this label to trigger release tests in CI labels Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby approved these changes

Assignees
No one assigned
Labels
contributions welcome do not merge run release CIs Use this label to trigger release tests in CI topic: build Issues related to ONNX builds and packages
Projects
PR Tracker
Status: Reviewer approved
Milestone
1.19
Development

Successfully merging this pull request may close these issues.
8 participants
@andife @justinchuby @colesbury @ilya-lavrenov @cyyever @mgorny @fs-eire @titaiwangms