[WIP] Fix report to exclude case-different attribute changes#586
Draft
[WIP] Fix report to exclude case-different attribute changes#586
Conversation
…ry counts Issue 109: Resources with only Azure resource ID casing differences are excluded from model.Changes (displayChanges filter) but still counted in model.Summary.ToChange. Root cause: summary computed from allChanges before the displayChanges filter runs. PR #574 fixed display suppression but missed updating summary computation. Analysis covers: - Root cause in ReportModelBuilder.Build.cs lines 44-46 vs 64-73 - What PR #574 did and didn't fix - Suggested fix approach (IsEffectivelyChanged predicate) - Required new test cases (TC-20 through TC-23)
…azure-id-case-changes is enabled Previously, resources with only Azure ID casing differences were hidden from the resource list in the report body (PR #574), but were still counted in the summary header (toChange count and Total). This fix: 1. Extracts IsEffectivelyVisible() helper capturing the visibility predicate 2. Creates summaryChanges by pre-filtering allChanges when the flag is active 3. Uses summaryChanges for all summary count calculations 4. Simplifies the displayChanges filter to reuse IsEffectivelyVisible() New tests TC-20, TC-21, TC-22 verify that summary counts are consistent with the displayed resource list when the filter is enabled.
Copilot stopped work on behalf of
oocx due to an error
March 5, 2026 10:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.