Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add deleteitem function to write interface #16

Merged
merged 11 commits into from
Sep 10, 2024
Merged

feat: add deleteitem function to write interface #16

merged 11 commits into from
Sep 10, 2024

Conversation

vankongv
Copy link
Contributor

@vankongv vankongv commented Sep 4, 2024 •
edited
Loading

Added for DeleteItem to WriteAPI interface.
Updated README for correct docker run command

@shidil
Copy link
Member

shidil commented Sep 4, 2024

Prefer table driven tests. They allow adding new cases easily.

shidil
shidil requested changes Sep 4, 2024
View reviewed changes
Copy link
Member

@shidil shidil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test does not check if it deletes more items than expected.
Try to add more seed data to the table than just one.
When there are more items, verify if the correct item was removed.

shidil
shidil reviewed Sep 6, 2024
View reviewed changes
tests/delete_item_test.go Outdated Show resolved Hide resolved
@vankongv vankongv requested a review from shidil September 6, 2024 03:34
NalinSajwan
NalinSajwan reviewed Sep 10, 2024
View reviewed changes
Copy link

@NalinSajwan NalinSajwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added code enhancing test cases.

tests/delete_item_test.go Outdated Show resolved Hide resolved
@vankongv
Copy link
Contributor Author

image New test cases passed

NalinSajwan
NalinSajwan reviewed Sep 10, 2024
View reviewed changes
tests/delete_item_test.go Outdated Show resolved Hide resolved
tests/seedTable.go Outdated Show resolved Hide resolved
tests/seedTable.go Outdated Show resolved Hide resolved
@vankongv vankongv changed the title feat: implement delete item function feat: add deleteitem function to write interface Sep 10, 2024
shidil
shidil approved these changes Sep 10, 2024
View reviewed changes
delete_item.go Outdated Show resolved Hide resolved
delete_item.go Outdated Show resolved Hide resolved
@shidil shidil added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit aaced21 Sep 10, 2024
3 checks passed
@shidil shidil deleted the add-delete-item branch September 10, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NalinSajwan NalinSajwan NalinSajwan left review comments

@shidil shidil shidil approved these changes

@omkar-till omkar-till Awaiting requested review from omkar-till

@hoang-tillpos hoang-tillpos Awaiting requested review from hoang-tillpos

@GaneshTILLX GaneshTILLX Awaiting requested review from GaneshTILLX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vankongv @shidil @NalinSajwan