Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade dependencies #7

Merged
merged 1 commit into from
Jan 4, 2024
Merged

chore(deps): upgrade dependencies #7

merged 1 commit into from
Jan 4, 2024

Conversation

shidil
Copy link
Member

@shidil shidil commented Dec 21, 2023

- github.com/aws/aws-sdk-go-v2 v1.21.2
- github.com/aws/aws-sdk-go-v2/config v1.19.1
- github.com/aws/aws-sdk-go-v2/credentials v1.13.43
- github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue v1.10.43
- github.com/aws/aws-sdk-go-v2/service/dynamodb v1.23.0


+ github.com/aws/aws-sdk-go-v2 v1.24.0
+ github.com/aws/aws-sdk-go-v2/config v1.26.2
+ github.com/aws/aws-sdk-go-v2/credentials v1.16.13
+ github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue v1.12.13
+ github.com/aws/aws-sdk-go-v2/service/dynamodb v1.26.7

Test Results

❯ make test
mkdir -p ./coverage
go vet ./...
go test -v ./... -coverprofile ./coverage/profile
?   	github.com/oolio-group/dynago	[no test files]
=== RUN   TestEncode
=== RUN   TestEncode/0
=== RUN   TestEncode/1
=== RUN   TestEncode/2
=== RUN   TestEncode/3
--- PASS: TestEncode (0.00s)
    --- PASS: TestEncode/0 (0.00s)
    --- PASS: TestEncode/1 (0.00s)
    --- PASS: TestEncode/2 (0.00s)
    --- PASS: TestEncode/3 (0.00s)
=== RUN   TestDecode
=== RUN   TestDecode/0
=== RUN   TestDecode/1
--- PASS: TestDecode (0.00s)
    --- PASS: TestDecode/0 (0.00s)
    --- PASS: TestDecode/1 (0.00s)
=== RUN   TestEncodeDecode
=== RUN   TestEncodeDecode/0
    cursor_test.go:135: eyJQayI6IiIsIlNrIjoiIiwiVGltZXN0YW1wIjowLCJUaW1lc2VyaWVzIjoiIn0K
=== RUN   TestEncodeDecode/1
    cursor_test.go:135: eyJQayI6InNvbWUjdmFsdWUiLCJTayI6ImFub3RoZXJfdmFsdWUiLCJUaW1lc3RhbXAiOjk5OTk5OTk5OSwiVGltZXNlcmllcyI6Im5vdF9hLW51bWJlciJ9Cg==
=== RUN   TestEncodeDecode/2
    cursor_test.go:135: eyJQayI6IiIsIlNrIjoiYW5vdGhlcl92YWx1ZSIsIlRpbWVzdGFtcCI6OTk5OTk5OTk5LCJUaW1lc2VyaWVzIjoibm90X2EtbnVtYmVyIn0K
=== RUN   TestEncodeDecode/3
    cursor_test.go:135: eyJQayI6InNvbWUjdmFsdWUiLCJTayI6ImFub3RoZXJfdmFsdWUiLCJUaW1lc3RhbXAiOjAsIlRpbWVzZXJpZXMiOiIifQo=
--- PASS: TestEncodeDecode (0.00s)
    --- PASS: TestEncodeDecode/0 (0.00s)
    --- PASS: TestEncodeDecode/1 (0.00s)
    --- PASS: TestEncodeDecode/2 (0.00s)
    --- PASS: TestEncodeDecode/3 (0.00s)
PASS
coverage: 88.0% of statements
ok  	github.com/oolio-group/dynago/pagination	0.002s	coverage: 88.0% of statements
go tool cover -html ./coverage/profile -o ./coverage/index.html
cd tests && go test -v ./...
=== RUN   TestNewClient
--- PASS: TestNewClient (0.00s)
=== RUN   TestNewClientLocalEndpoint
--- PASS: TestNewClientLocalEndpoint (3.11s)
=== RUN   TestQuery
=== RUN   TestQuery/no_query_matches
=== RUN   TestQuery/error_prone_query
2023/12/21 19:42:59 dynamodb query pk - invalid failed; operation error DynamoDB: Query, https response error StatusCode: 400, RequestID: 4c78c187-babd-4a9d-bac0-48023337ce43, api error ValidationException: ExpressionAttributeValues must not be empty
=== RUN   TestQuery/query_in_partition_with_sk_matching_prefix
=== RUN   TestQuery/query_with_contains_filter_condition_on_field
=== RUN   TestQuery/query_with_limit_on_items_returned
--- PASS: TestQuery (4.38s)
    --- PASS: TestQuery/no_query_matches (0.04s)
    --- PASS: TestQuery/error_prone_query (0.02s)
    --- PASS: TestQuery/query_in_partition_with_sk_matching_prefix (0.01s)
    --- PASS: TestQuery/query_with_contains_filter_condition_on_field (0.01s)
    --- PASS: TestQuery/query_with_limit_on_items_returned (0.00s)
=== RUN   TestQueryPagination
=== RUN   TestQueryPagination/no_limit,_auto_paginate_1MB_chunks_of_records
=== RUN   TestQueryPagination/100_items_within_1MB_page
=== RUN   TestQueryPagination/limit_of_1500_spanning_2_1MB_pages
=== RUN   TestQueryPagination/limit_of_2500_spanning_3_1MB_pages
=== RUN   TestQueryPagination/paginate_100_items_per_page;_each_page_<_1MB
--- PASS: TestQueryPagination (4.64s)
    --- PASS: TestQueryPagination/no_limit,_auto_paginate_1MB_chunks_of_records (0.13s)
    --- PASS: TestQueryPagination/100_items_within_1MB_page (0.00s)
    --- PASS: TestQueryPagination/limit_of_1500_spanning_2_1MB_pages (0.03s)
    --- PASS: TestQueryPagination/limit_of_2500_spanning_3_1MB_pages (0.05s)
    --- PASS: TestQueryPagination/paginate_100_items_per_page;_each_page_<_1MB (0.08s)
=== RUN   TestTransactItems
=== RUN   TestTransactItems/assign_terminal_-_only_add_a_terminal
=== RUN   TestTransactItems/assign_terminal_-_delete_existing_and_update_with_new
--- PASS: TestTransactItems (2.63s)
    --- PASS: TestTransactItems/assign_terminal_-_only_add_a_terminal (0.05s)
    --- PASS: TestTransactItems/assign_terminal_-_delete_existing_and_update_with_new (0.01s)
PASS
ok  	github.com/oolio-group/dynago/tests	14.756s

Signed-off-by: Shidil Eringa <shidil@live.com>

This PR has 212 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Large
Size       : +104 -108
Percentile : 61.2%

Total files changed: 4

Change summary by file extension:
.mod : +34 -36
.sum : +70 -72

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@shidil shidil added this pull request to the merge queue Jan 4, 2024
Merged via the queue into main with commit 3bfa0c4 Jan 4, 2024
3 checks passed
@shidil shidil deleted the chore-deps-upgrade branch January 4, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants