-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Changed the table name in delete item to use client tablename #8
fix: Changed the table name in delete item to use client tablename #8
Conversation
@thusharprakash Please configure commit signing, and rebase pull request. Follow https://docs.github.com/en/authentication/managing-commit-signature-verification After configuring signing rebase with |
Head branch was pushed to by a user without write access
9e88145
to
3379580
Compare
3379580
to
cedef7f
Compare
@thusharprakash Cannot merge this PR until your commits are signed. |
…dynamodb client Signed-off-by: Thushar M Prakash <thushar@arezlabs.com> Signed-off-by: Thushar M Prakash <thushar.prakash@oolio.com>
cedef7f
to
39845bf
Compare
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Description:
Changes Made:
The deleteItem function is currently relying on the table name fetched from the environment variable. This requires the maintenance of a separate variable named DYNAMODB_TABLE for the function to operate correctly. To align with the consistency of the codebase and ensure uniformity, I have made modifications to the function. The updated implementation now utilizes the table name configured for the DynamoDB client, bringing it in line with the approach adopted by other functions. This adjustment addresses an oversight where the deleteItem function was not following the same convention as other functions in handling the DynamoDB table name.
Key Points:
Before:
deleteItem function used the table name from the DYNAMODB_TABLE environment variable.
Required a separate variable (DYNAMODB_TABLE) for correct functionality.
After:
Modified deleteItem to use the table name configured for the DynamoDB client.
Ensures consistency with other functions in the codebase.
Reason for the Change:
To maintain code consistency and streamline the usage of DynamoDB table names across functions. This change eliminates the need for a separate environment variable (DYNAMODB_TABLE) specific to the deleteItem function, aligning it with the established configuration pattern used by other functions.
Related Issues:
#9