Skip to content

Conversation

@JackWilli
Copy link
Contributor

No description provided.

@JackWilli JackWilli requested a review from ptdewey December 8, 2024 18:37
should create the dir if it doesn't exist
@JackWilli JackWilli requested a review from ptdewey December 11, 2024 23:08
Moved db close defer to avoid potential race condition
@ptdewey
Copy link
Contributor

ptdewey commented Dec 11, 2024

Also make sure to update the example config and readme with the new option(s) you add

Copy link
Contributor

@ptdewey ptdewey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we just need the new config options documented before merging

@JackWilli JackWilli requested a review from ptdewey December 13, 2024 17:37
Copy link
Contributor

@ptdewey ptdewey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JackWilli JackWilli merged commit 21229f5 into main Dec 13, 2024
1 check passed
@JackWilli JackWilli deleted the pinning branch December 13, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants