[backport] feat: add support for OpenBSD

This diff backports #703 to the release/3.14 branch. See ooni/probe#2067
ooni · Apr 12, 2022 · 5dcd8a0 · 5dcd8a0
1 parent 2f95f49
commit 5dcd8a0
Show file tree

Hide file tree

Showing 5 changed files with 310 additions and 4 deletions.
diff --git a/internal/netxlite/errno_openbsd.go b/internal/netxlite/errno_openbsd.go
diff --git a/internal/netxlite/errno_openbsd_test.go b/internal/netxlite/errno_openbsd_test.go
diff --git a/internal/netxlite/internal/generrno/main.go b/internal/netxlite/internal/generrno/main.go
@@ -173,7 +173,7 @@ var Specs = []*ErrorSpec{
 // of the related golang.org/x/sys/$name library.
 func mapSystemToLibrary(system string) string {
 	switch system {
-	case "darwin", "freebsd", "linux":
+	case "darwin", "freebsd", "openbsd", "linux":
 		return "unix"
 	case "windows":
 		return "windows"
@@ -364,6 +364,7 @@ func writeSystemSpecificTestFile(system string) {
 var SupportedSystems = []string{
 	"darwin",
 	"freebsd",
+	"openbsd",
 	"linux",
 	"windows",
 }

diff --git a/internal/platform/platform.go b/internal/platform/platform.go
@@ -18,7 +18,9 @@ import "runtime"
 //
 // 5. "freebsd"
 //
-// 6. "unknown"
+// 6. "openbsd"
+//
+// 7. "unknown"
 //
 // You should use this name to annotate measurements.
 func Name() string {
@@ -32,7 +34,7 @@ func name(goos string) string {
 	//
 	// See https://golang.org/doc/go1.16#darwin
 	switch goos {
-	case "android", "freebsd", "ios", "linux", "windows":
+	case "android", "freebsd", "openbsd", "ios", "linux", "windows":
 		return goos
 	case "darwin":
 		return "macos"

diff --git a/internal/platform/platform_test.go b/internal/platform/platform_test.go
@@ -8,7 +8,7 @@ import (
 func TestGood(t *testing.T) {
 	var expected bool
 	switch Name() {
-	case "android", "freebsd", "ios", "linux", "macos", "windows":
+	case "android", "freebsd", "openbsd", "ios", "linux", "macos", "windows":
 		expected = true
 	}
 	if !expected {
@@ -26,6 +26,9 @@ func TestName(t *testing.T) {
 	}, {
 		expected: "freebsd",
 		goos:     "freebsd",
+	}, {
+		expected: "openbsd",
+		goos:     "openbsd",
 	}, {
 		expected: "ios",
 		goos:     "ios",