Skip to content

Unsupported class file version reduced to warning once #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Unsupported class file version reduced to warning once #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions OPAL/bi/src/main/scala/org/opalj/bi/reader/ClassFileReader.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ import org.opalj.control.fillArrayOfInt
import org.opalj.io.process
import org.opalj.log.OPALLogger.error
import org.opalj.log.OPALLogger.info
import org.opalj.log.OPALLogger.logOnce
import org.opalj.log.Warn

import org.apache.commons.text.similarity.LevenshteinDistance

Expand Down Expand Up @@ -241,7 +243,8 @@ trait ClassFileReader extends ClassFileReaderConfiguration with Constant_PoolAbs
def unsupportedVersion =
s"unsupported class file version: $major_version.$minor_version" +
" (Supported: 45(Java 1.1) <= version <= " +
s"$LatestSupportedJavaMajorVersion(${jdkVersion(LatestSupportedJavaMajorVersion)}))"
s"$LatestSupportedJavaMajorVersion(${jdkVersion(LatestSupportedJavaMajorVersion)})); " +
"analyses might still work, but fail or produce incorrect results when unsupported features are used"

// let's make sure that we support this class file's version
if (major_version < 45) // at least JDK 1.1 or we back out
Expand All @@ -254,7 +257,7 @@ trait ClassFileReader extends ClassFileReaderConfiguration with Constant_PoolAbs
) {
// Just log an error message for newer version, we might still be able to handle the
// class if it doesn't use any features introduced in an unsupported version
error("class file reader", unsupportedVersion)
logOnce(Warn("class file reader", unsupportedVersion))
}

val cp = Constant_Pool(in)
Expand Down