Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Translation README.md for workflow #907

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

louie-tsai
Copy link
Collaborator

@louie-tsai louie-tsai commented Oct 8, 2024

Description

Added a workflow for VideoQnA following what ChatQnA has. ChatQnA flow

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

na

Tests

Describe the tests that you ran to verify your changes.

@louie-tsai louie-tsai force-pushed the translation_workflow branch 2 times, most recently from 70ade15 to 418fe50 Compare October 8, 2024 05:38

LLM_gen{{LLM Service <br>}}
GW([Translation GateWay<br>]):::orange
NG([Nginx MicroService]):::blue
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why nginx is in the front of the user input?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a nginx microservice as a proxy server in docker compose, and UI server depends it.
https://github.com/opea-project/GenAIExamples/blob/main/Translation/docker_compose/intel/hpu/gaudi/compose.yaml#L77

should I remove it or put it somewhere else in the workflow?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated them accordingly.

@louie-tsai louie-tsai force-pushed the translation_workflow branch 2 times, most recently from 274cff5 to f57bf26 Compare October 8, 2024 16:13
@louie-tsai louie-tsai force-pushed the translation_workflow branch 4 times, most recently from 68b5598 to d0fbe5e Compare October 14, 2024 21:49
Signed-off-by: Tsai, Louie <louie.tsai@intel.com>
Signed-off-by: Tsai, Louie <louie.tsai@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants