remove nogus array flip in 2D adv-diff example + code cleanup

[AgnieszkaZaba]

No description provided.

[pawelmagnu]

I am not sure if this is a debug leftover; when plotting images pixel 0,0 is in the top left in matplotlib, but in most visualizations, it is in the bottom left, so I guess this flip is necessary

[AgnieszkaZaba]

I am not sure if this is a debug leftover; when plotting images pixel 0,0 is in the top left in matplotlib, but in most visualizations, it is in the bottom left, so I guess this flip is necessary

Maybe something changed because I run this notebook yesterday and saved animation was flipped (compared to initial and final plots). Could you check it?

[slayoo]

Note: imshow features the origin parameter which is set to upper by default, but can be changed to lower: https://matplotlib.org/stable/users/explain/artists/imshow_extent.html

Also, it would be best to use the plot function also within animation generation to ensure that the data are plotted in exactly the same way both in the plots and in the animation.

[slayoo]

@AgnieszkaZaba, @pawelmagnu, ping :) let's sort this one out!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (6d161a2) to head (8288129).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #468   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files          30       30           
  Lines        1468     1468           
=======================================
  Hits         1351     1351           
  Misses        117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[pawelmagnu]

I think we still need to remove the flipud statement

[AgnieszkaZaba]

I think we still need to remove the flipud statement

Ok, we can remove flipud. But then if we set 'origin' to 'lower', we have to do the same for previous plots.

[AgnieszkaZaba]

Now it using plot function (as @slayoo suggested).
@pawelmagnu extra parameter was added to plot function (for deciding if colorbar should be shown). Maybe there is a better way to do this?