Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests to the resource controller #299

Open
1 of 19 tasks
frewilhelm opened this issue Oct 21, 2024 · 0 comments · May be fixed by open-component-model/ocm-k8s-toolkit#47
Open
1 of 19 tasks

Add more tests to the resource controller #299

frewilhelm opened this issue Oct 21, 2024 · 0 comments · May be fixed by open-component-model/ocm-k8s-toolkit#47
Assignees
@frewilhelm
Labels
area/ipcei Important Project of Common European Interest component/ocm-controllers OCM Controllers kind/task small task, normally part of feature or epic

Comments

@frewilhelm
Copy link

frewilhelm commented Oct 21, 2024 •
edited
Loading

Description

In open-component-model/ocm-k8s-toolkit#30 only one test is created. However, we need more tests to have an appropriate code coverage.

  • Refactor BeforeFunc-parts to be more generic
  • Add tests that
    • reconciliation works as planned
    • reconciliation stops when requirements are not met
    • reconciliation starts again when the resource changes
    • reconciliation starts again when component changes
    • reconciliation starts again when artifact (owned by resource-controller) changes
    • check downgradibility (if this is applicable in this context?)
    • finalizers is added/removed/used
  • Unit tests for helper functions in resource controller

Done Criteria

  • ...
  • Code has been reviewed by other team members
  • Internal technical Documentation created/updated
  • New / changed code is documented
  • Analysis of existing tests (Unit and Integration)
  • Unit Tests created for new code or existing Unit Tests updated
  • Integration Test Suite updated (includes deletion of existing unnecessary Integration Test and/or creation of new ones if required)
  • Enduser Documentation updated (if applicable)
  • Successful demonstration in Review
@frewilhelm frewilhelm added the kind/task small task, normally part of feature or epic label Oct 21, 2024
@github-actions github-actions bot added the area/ipcei Important Project of Common European Interest label Oct 21, 2024
@frewilhelm frewilhelm self-assigned this Oct 23, 2024
@frewilhelm frewilhelm moved this from 🆕 ToDo to 🏗 In Progress in OCM Backlog Board Oct 23, 2024
@frewilhelm frewilhelm linked a pull request Oct 23, 2024 that will close this issue
Draft
@frewilhelm frewilhelm changed the title Add more tests Add more tests to the resource controller Oct 31, 2024
@morri-son morri-son added the component/ocm-controllers OCM Controllers label Oct 31, 2024
@morri-son morri-son added this to the 2024-Q4 milestone Oct 31, 2024
@frewilhelm frewilhelm moved this from 📋 Next-UP to 🆕 ToDo in OCM Backlog Board Jan 9, 2025
@morri-son morri-son removed this from the 2024-Q4 milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frewilhelm frewilhelm

Labels
area/ipcei Important Project of Common European Interest component/ocm-controllers OCM Controllers kind/task small task, normally part of feature or epic
Projects
OCM Backlog Board
Status: 🆕 ToDo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add tests to the resource reconciler open-component-model/ocm-k8s-toolkit
2 participants
@frewilhelm @morri-son