Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tests to the resource reconciler #47

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

frewilhelm
Copy link
Contributor

What this PR does / why we need it:

More tests to test functionality.

Which issue(s) this PR fixes:

Closes open-component-model/ocm-project#299

@frewilhelm frewilhelm self-assigned this Oct 23, 2024
@frewilhelm frewilhelm changed the title create BeforeEach-func for components chore: add tests to the resource reconciler Oct 23, 2024
@frewilhelm frewilhelm force-pushed the addTestsResourceController branch from 0888d79 to c34ddd1 Compare October 30, 2024 14:45
@@ -51,7 +51,7 @@ import (

const (
ARTIFACT_PATH = "ocm-k8s-artifactstore--*"
ARTIFACT_SERVER = "localhost:8080"
ARTIFACT_SERVER = "localhost:0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh?

@hilmarf hilmarf added the kind/chore chore, maintenance, etc. label Nov 28, 2024
Copy link

This pull request was marked as stale because it has not had recent activity.

@github-actions github-actions bot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore chore, maintenance, etc. lifecycle/stale Nobody worked on this for 6 months (will further age)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more tests to the resource controller
3 participants