feature: add resolvers to component spec #38
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will not solve our problem in regard to enabling the replication controller to use the resolver configuration from the component without having apply the entire configuration with possible unintended side effects. This is because, in order to get the credentials for the corresponding resolvers, the component configuration would still have to be applied. |
|
@fabianburth can we close this or are you planning on revisiting this problem in a different way? |
|
This pull request was marked as stale because it has not had recent activity. |
github-actions
bot
added
the
lifecycle/stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds Resolvers to the component specification.
This is necessary because the resolvers cannot be specified within the ocm config of the component. This is because the replication controller also has to use these resolvers BUT it is not possible to only apply particular parts of a ocm config. So without this dedicated field, the replication controller would have to apply the entire ocm config of the component, which may contain a lot more than just the resolvers.
Which issue(s) this PR fixes: