Implement Single Layer OCI Artifacts #98
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frewilhelm
force-pushed
the
impl_artifacts
branch
2 times, most recently
from
a39704d to
28cc46a
Compare
frewilhelm
changed the title
frewilhelm
force-pushed
the
impl_artifacts
branch
7 times, most recently
from
f1c1f69 to
cbe7736
Compare
frewilhelm
force-pushed
the
impl_artifacts
branch
3 times, most recently
from
e168ef4 to
45ce876
Compare
frewilhelm
force-pushed
the
impl_artifacts
branch
from
45ce876 to
9568d38
Compare
ikhandamirov
added a commit
that referenced
this pull request
Feb 7, 2025
#### What this PR does / why we need it With this PR an in-cluster instance of `zot` OCI registry will be deployed aside to the controllers: * `make deploy-dev` makes `zot` accessible via http. * `make deploy` makes `zot` accessible via https. #### Which issue(s) this PR fixes This PR is in the context of #75 and should be merged before #98
frewilhelm
force-pushed
the
impl_artifacts
branch
3 times, most recently
from
2458ab5 to
d9af52c
Compare
Closed
frewilhelm
force-pushed
the
impl_artifacts
branch
5 times, most recently
from
2e78025 to
4b0a1ce
Compare
frewilhelm
force-pushed
the
impl_artifacts
branch
4 times, most recently
from
e0fd87f to
ac6759c
Compare
frewilhelm
force-pushed
the
impl_artifacts
branch
8 times, most recently
from
ce9492f to
847f0e1
Compare
frewilhelm
force-pushed
the
impl_artifacts
branch
from
847f0e1 to
b0a18be
Compare
fixes the reconciler tests by optimizing them and cleaning them up. To remove a potential race of the test and the control loop I had to introduce a finalizer on the component that serializes the deletion of the snapshots. (even though we are aware that envtest cannot delete with ownerrefs) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. -->
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| var extractedData bytes.Buffer | ||
| //nolint:gosec // TODO: Decision needed | ||
| if _, err := io.Copy(&extractedData, tarReader); err != nil { |
Check failure
Code scanning / gosec
Potential DoS vulnerability via decompression bomb Error
| } | ||
|
|
||
| // Open the file | ||
| f, err := os.Open(file) |
Check failure
Code scanning / gosec
Potential file inclusion via variable Error
| Expect(err).NotTo(HaveOccurred()) | ||
|
|
||
| // Start zot-registry | ||
| zotCmd := exec.Command(binPath, "serve", configFile) |
Check failure
Code scanning / gosec
Subprocess launched with variable Error test
unused import removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75