Skip to content

Conversation

@vasu1124
Copy link
Contributor

What this PR does / why we need it

go 1.25 only available in nix-unstable

@vasu1124 vasu1124 requested a review from a team as a code owner August 28, 2025 13:34
@github-actions github-actions bot added kind/bugfix Bug kind/skip-release-notes Pull request will not appear in release notes size/s Small labels Aug 28, 2025
Signed-off-by: vasu1124 <vasu1124@actvirtual.com>
Copy link
Member

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am aware of nix builds failing but I don't think we want to publish a nix build from unstable. Thus, we should rather wait here until nix publishes a version with go1.25. WDYT?

@jakobmoellerdev
Copy link
Member

closing in favor of 1654

jakobmoellerdev added a commit that referenced this pull request Nov 4, 2025
<!-- markdownlint-disable MD041 -->
#### What this PR does / why we need it
Bump go version used in flake from 1.24 to 1.25.
#### Which issue(s) this PR is related to
<!--
Usage: `Related to #<issue number>`, or `Related to (paste link of
issue)`.
-->
Related to PR #1596

I noticed while creating this PR that there is already a PR tackling
this but it was created when go 1.25 was not yet in stable.
I hope you don't mind me opening a second PR

Signed-off-by: Tim <32556895+Avarei@users.noreply.github.com>
Co-authored-by: Jakob Möller <jakob.moeller@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bugfix Bug kind/skip-release-notes Pull request will not appear in release notes size/s Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants