feat(condo): DOMA-9269 move receipts upload to extension tab #5027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abshnko
added
the
🔬 WIP
pahaz
reviewed
Aug 2, 2024
| @@ -59,7 +59,7 @@ export const MainContent: React.FC<MainContentProps> = ({ | |||
| result.push({ | |||
| label: extensionPageTitle, | |||
| key: EXTENSION_TAB_KEY, | |||
| children: <IFrame src={appUrl} reloadScope='organization' withPrefetch withLoader withResize/>, | |||
| children: <IFrame src={appUrl} reloadScope='organization' withPrefetch withLoader withResize scrolling='yes' />, | |||
There was a problem hiding this comment.
it's better to control it by child window. @SavelevMatthew check it please
pahaz
reviewed
Aug 2, 2024
| onLoad={handleLoad} | ||
| hidden={isLoading || isError || hidden} | ||
| ref={handleRefChange} | ||
| height={frameHeight} | ||
| // NOTE: Deprecated, but overflow: hidden still not works in Chrome :) | ||
| scrolling='no' | ||
| scrolling={scrolling} |
abshnko
force-pushed
the
feat/condo/DOMA-9269/new-registry-upload-form
branch
from
d49040b
to
bfcdc4f
Compare
abshnko
force-pushed
the
feat/condo/DOMA-9269/new-registry-upload-form
branch
from
bfcdc4f
to
89ab71e
Compare
abshnko
force-pushed
the
feat/condo/DOMA-9269/new-registry-upload-form
branch
from
89ab71e
to
8bc0513
Compare
abshnko
force-pushed
the
feat/condo/DOMA-9269/new-registry-upload-form
branch
from
8bc0513
to
1a4f735
Compare
abshnko
force-pushed
the
feat/condo/DOMA-9269/new-registry-upload-form
branch
from
1a4f735
to
3e26acf
Compare
abshnko
force-pushed
the
feat/condo/DOMA-9269/new-registry-upload-form
branch
from
3e26acf
to
7546c0f
Compare
abshnko
force-pushed
the
feat/condo/DOMA-9269/new-registry-upload-form
branch
from
00b22f0
to
6e6a7e7
Compare
abshnko
force-pushed
the
feat/condo/DOMA-9269/new-registry-upload-form
branch
from
6e6a7e7
to
8809f56
Compare
abshnko
force-pushed
the
feat/condo/DOMA-9269/new-registry-upload-form
branch
from
a9d0194
to
59944da
Compare
|
abshnko
force-pushed
the
feat/condo/DOMA-9269/new-registry-upload-form
branch
from
59944da
to
672b52a
Compare
abshnko
force-pushed
the
feat/condo/DOMA-9269/new-registry-upload-form
branch
from
42ab681
to
05c0430
Compare
abshnko
force-pushed
the
feat/condo/DOMA-9269/new-registry-upload-form
branch
from
5b28164
to
cbe3c60
Compare
abshnko
force-pushed
the
feat/condo/DOMA-9269/new-registry-upload-form
branch
from
cbe3c60
to
3f4ed45
Compare
abshnko
force-pushed
the
feat/condo/DOMA-9269/new-registry-upload-form
branch
from
3f4ed45
to
a20c364
Compare
abshnko
force-pushed
the
feat/condo/DOMA-9269/new-registry-upload-form
branch
from
3e6f94f
to
82efdd2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] New flow for uploading receipts in integrations
Now uploading will be in the extension tab with history of uploading