feat(condo): DOMA-9944 parse QR code in base64 format in ValidateQRCodeService #5217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoviazin
approved these changes
Sep 16, 2024
VKislov
force-pushed
the
DOMA-9944/condo/feat/parse-qr-code-from-base64-string
branch
from
744fb56
to
2968d76
Compare
AleX83Xpert
reviewed
Sep 17, 2024
apps/condo/domains/billing/utils/countrySpecificQRCodeParsers/ru.qrCodeParser.js
Outdated
Show resolved
Hide resolved
apps/condo/domains/billing/utils/countrySpecificQRCodeParsers/ru.qrCodeParser.js
Show resolved
Hide resolved
AleX83Xpert
reviewed
Sep 18, 2024
apps/condo/domains/billing/utils/countrySpecificQRCodeParsers/ru.qrCodeParser.js
Show resolved
Hide resolved
apps/condo/domains/billing/utils/countrySpecificQRCodeParsers/ru.qrCodeParser.js
Outdated
Show resolved
Hide resolved
|
It looks like you should add at least one REAL WORLD TEST CASE where we have a problem with encoding. |
AleX83Xpert
reviewed
Oct 4, 2024
apps/condo/domains/billing/utils/countrySpecificQRCodeParsers/ru.qrCodeParser.js
Outdated
Show resolved
Hide resolved
AleX83Xpert
reviewed
Oct 9, 2024
apps/condo/domains/billing/utils/countrySpecificQRCodeParsers/ru.qrCodeParser.js
Outdated
Show resolved
Hide resolved
apps/condo/domains/billing/utils/countrySpecificQRCodeParsers/ru.qrCodeParser.js
Outdated
Show resolved
Hide resolved
apps/condo/domains/billing/utils/countrySpecificQRCodeParsers/ru.qrCodeParser.js
Outdated
Show resolved
Hide resolved
apps/condo/domains/billing/utils/countrySpecificQRCodeParsers/ru.qrCodeParser.js
Outdated
Show resolved
Hide resolved
AleX83Xpert
approved these changes
Oct 9, 2024
|
|
||
| if (!matches) { | ||
| logger.error({ msg:'Error qr-code parsing', data: { qrStr, decodedRequisitesStr: decodedQrStr, detectedEncoding } }) |
There was a problem hiding this comment.
Suggested change
| logger.error({ msg:'Error qr-code parsing', data: { qrStr, decodedRequisitesStr: decodedQrStr, detectedEncoding } }) | |
| logger.error({ msg:'Error qr-code parsing', data: { qrStr, decodedQrStr, detectedEncoding } }) |
| throw new Error('Invalid QR code') | ||
| } | ||
| logger.info({ msg:'Parsed qr-code', data: { qrStr, decodedRequisitesStr: decodedQrStr, detectedEncoding } }) |
There was a problem hiding this comment.
Suggested change
| logger.info({ msg:'Parsed qr-code', data: { qrStr, decodedRequisitesStr: decodedQrStr, detectedEncoding } }) | |
| logger.info({ msg:'Parsed qr-code', data: { qrStr, decodedQrStr, detectedEncoding } }) |
VKislov
force-pushed
the
DOMA-9944/condo/feat/parse-qr-code-from-base64-string
branch
from
c8bd005
to
af09626
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.