-
Notifications
You must be signed in to change notification settings - Fork 4
feat: Reintroduce Monitoring option using CDK Monitoring Constructs. #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi, any timeline for this PR? |
|
Currently got a bunch of work stuff to do, so will probably return to this one by the end of next week. Do you have any input on how the dashboard should look? |
e72aa62 to
373de6c
Compare
|
...that was a long week, eh? I ended up despairing over the feeling that I don't really grok cdk-monitoring-constructs. I should get back to this. |
…cs from all endpoint functions into common widgets
…files the right way for this?
a0060e3 to
ccc494f
Compare
ccc494f to
dc1e41f
Compare
|
Rechecked the old PR and rebased it onto a current state. Open points:
|
There is some stateful wonkery inside, because cdk-monitoring-constructs lacks functionality for influencing the layout of a dashboard
c9cde58 to
2d84aa3
Compare
|
I forgot: cdk-monitoring-constructs still does not support any way to influence widget ordering or sizing on the generated dashboards. For now I've separated initializing the function monitoring and adding it to the overall MonitoringFacade, so that leaves a chance for the API and DynamoDB monitoring in the API subclasses to be initialized. Still not sure about the GraphQL part, but this should at least do for monitoring RestAPIs. |

Re-add the monitoring option from cdk-serverless v1. This implementation builds on the
cdk-monitoring-constructslibrary in hopes of keeping implementation effort for anything monitorting- and alerting-related low.There's a monitoring flag on the cdk-serverless' API constructs, but it currently does nothing.
A Cloudwatch dashboard with monitoring widgets for each API construct, including its endpoint Lambdas will be created if the monitoring flag is activated.
As cdk-monitoring-constructs currently requires at least aws-cdk v2.112.0, this will raise the minimum required CDK version on cdk-serverless.
Currently a rough draft, just to get something started as a discussion point on where to go. Not 100% sure about the usefulness of cdk-monitoring-constructs, I'm planning on evaluating it within the scope of this PR or return to a custom implementation if it proves not to be a good fit.
At the very least, I'd like to see the old Cloudwatch dashboard reconstructed. If possible, I want this to provide a base for an easy alerting abstraction over the API constructs, using Cloudwatch Alarms.