Skip to content

update dac member_name to controlled list #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
RabiaSajjad wants to merge 4 commits into
base: master
Choose a base branch
from
Open

update dac member_name to controlled list #1285

RabiaSajjad wants to merge 4 commits into from
+271 −5

Conversation

@RabiaSajjad
Copy link
Member

@RabiaSajjad RabiaSajjad commented May 20, 2022

No description provided.

@RabiaSajjad RabiaSajjad requested a review from wardi May 20, 2022 17:53
@wardi
Copy link
Member

wardi commented May 25, 2022

looks good

@JVickery-TBS
feat(tests): added dac member name tests;
0f456cb 
- Updated test to handle dac member choices.
@JVickery-TBS
Copy link
Contributor

JVickery-TBS commented May 8, 2023

Fixed test for dac. Conflict is easy enough, just need the self. on the lc.action.datastore_upsert, and keep the new choices_fields loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wardi wardi Awaiting requested review from wardi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RabiaSajjad @wardi @JVickery-TBS