Improved Constraint Error Messages & Delete Error Fixes #137
Conversation
- Include link to referenced table and filter.
- Fix delete errors. - Bring back upload form errors.
- Only markup safe the errors we output, specifically the constraint errors that do not have user input. - Handle the upsert constraint error messages.
- Further improvements to constraint errors.
- Further improvements to constraint errors.
- Flake8 fixes. - Pyright fixes.
- Added change log files.
|
@wardi I know we do this all at the View level, the formatting of error strings and DB trigger strings etc. But would it be better to do it at the logic level? That way we don't need to keep formatting the error strings in Recombinant and Canada views? And the error strings would be available in the API the same way they show in the views? |
- Build sql strings from ds info for ref records export to Excel.
|
Yes, it would be much better to have all the direct datastore SQL and parsing of error messages in the datastore/backends/postgres.py module. The view code should be only responsible for taking the results of action calls and rendering them with templates. |
- Included linked records in Excel template.
- Updated code for new ckan ds fk error handling.
- Flake8 fixes. - Pyright fixes.
wardi
left a comment
wardi
left a comment
There was a problem hiding this comment.
This looks much better @JVickery-TBS
We should steal the table designer delete UI at some point to simplify deletion in recombinant.
req: open-data/ckan#188