DataStore Dump & DataStore Field Sync #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DataStore dump for sysadmins only. - Delete old columns.
- Added change log files.
wardi
reviewed
Feb 7, 2025
wardi
reviewed
Feb 7, 2025
wardi
approved these changes
Feb 7, 2025
Member
wardi
left a comment
wardi
left a comment
There was a problem hiding this comment.
looks good (with comments above)
- Added delete_fields to recombinant update logic aciton method.
- Only allow sysadmins to refresh resources via the UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(dev): ds dump, delete old cols;
Came across a couple issues with loading in Excel templates, basically we already know if the resources' DS fields are out of sync with the Schema with the
datastore_correct. So just doing something with it to "refresh" the datastore table which will also now delete columns that are NOT in the schema, aligning any API users with datastore_search with the Schema of the Recombinant resource.Also, we came across a need to migrate just a couple of orgs' PD data for combining them into one org. So I have modified the load_csv and read_csv cli methods a bit to allow for this. And then added the DataStore Dump button for sysadmins here. This part requires: open-data/ckan#190