Updated Electronic Emission PDU for DIS7#20
Open
Werbaer-bot wants to merge 3 commits intoopen-dis:masterfrom
Open
Updated Electronic Emission PDU for DIS7#20Werbaer-bot wants to merge 3 commits intoopen-dis:masterfrom
Werbaer-bot wants to merge 3 commits intoopen-dis:masterfrom
Conversation
added 2 commits
January 19, 2026 13:10
Refactored ElectronicEmissionsPdu, EmissionSystem, and related classes to accurately implement the DIS 7.0.5 standard. Added a new Beam class, replaced incorrect system/beam structures with proper lists, and updated marshalling, reflection, and equality logic. Standardized namespaces, improved XML serialization, and cleaned up legacy code for correctness and maintainability.
Author
|
Please before merging send me your summary and then request for a change, i need to update a few comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have implemented the complete EE PDU with all its records. Do you see any problem?