-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add weth collateral #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like all params line up with the proposal. the differences with RETH on chain are mostly expected. The tax collector stability fee is a wierd one, I'm not sure how that's calculated.
}, | ||
"SAFEEngine_Address": "0xEff45E8e2353893BD0558bD5892A42786E9142F1", | ||
"TaxCollectorCollateralParams": { | ||
"stabilityFee": "1000000000472114805215157978" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stability fee for RETH:
1000000000550051944812439051
"LiquidationEngineCollateralParams": { | ||
"newCAHChild": "0x293b702362918e990Dd5f48a80fB139FeAd64263", | ||
"liquidationPenalty": "1050000000000000000", | ||
"liquidationQuantity": "50000000000000000000000000000000000000000000000000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the liquidation quantity for RETH on mainnet is:
100000000000000000000000000000000000000000000000000
here it's shows:
50000000000000000000000000000000000000000000000000
(just noting the difference, I know it 50k od vs 100k od)
liquidation penalty is the same
"ODGovernor_Address": "0xf704735CE81165261156b41D33AB18a08803B86F", | ||
"OracleRelayerCollateralParams": { | ||
"delayedOracle": "0x562CCE2F4dc383862dC6A926AF10DeFf5fCd172F", | ||
"safetyCRatio": "1200000000000000000000000000", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RETH saftey C ratio on mainnet:
1250000000000000000000000000
Reth liquidationCRatio on mainnet:
1200000000000000000000000000
See
https://commonwealth.im/open-dollar-governance/discussion/23828-collateral-expansion-to-weth-link-and-grt