Skip to content

fix(visualization): remove fields overiddes when set to None #3037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(visualization): remove fields overiddes when set to None #3037

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da64d26
Fix default fields initialization in visualizer
donnadamus Oct 17, 2025
ac16158
Merge pull request #1 from donnadamus/donnadamus-patch-1
donnadamus Oct 17, 2025
733c945
Merge branch 'main' into main
donnadamus Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/anomalib/visualization/image/visualizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ def __init__(
output_dir: str | Path | None = None,
) -> None:
super().__init__()
self.fields = fields or ["image", "gt_mask"]
self.fields = fields
Copy link

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting self.fields = fields without a fallback allows None to be assigned directly. This could cause issues downstream if code expects self.fields to be a list. Consider checking whether fields being None is handled properly throughout the class, or document this behavior explicitly if None is a valid value for visualization logic.

Suggested change
self.fields = fields
self.fields = fields or ["image", "gt_mask"]

Copilot uses AI. Check for mistakes.
self.overlay_fields = overlay_fields or [("image", ["anomaly_map"]), ("image", ["pred_mask"])]
self.field_size = field_size
self.fields_config = {**DEFAULT_FIELDS_CONFIG, **(fields_config or {})}
Expand Down