-
Notifications
You must be signed in to change notification settings - Fork 462
Implement endpoints to manage staged datasets #5370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements a complete set of REST API endpoints for managing staged datasets, enabling users to upload, list, retrieve, download, and delete dataset archives in a staging area.
Changes:
- Added new API endpoints for staged dataset operations (upload, list, get, download, delete)
- Implemented
StagedDatasetServicefor dataset file management and metadata inference - Added comprehensive unit and integration test coverage for the new endpoints and service
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| application/docs/api.md | Added API documentation for staged datasets endpoints |
| application/backend/tests/unit/routers/test_dataset_ie.py | Added unit tests for staged dataset API endpoints |
| application/backend/tests/unit/routers/conftest.py | Added type hint to test client fixture |
| application/backend/tests/integration/services/test_staged_dataset_service.py | Added integration tests for staged dataset service |
| application/backend/app/settings.py | Added staged_datasets_dir configuration setting |
| application/backend/app/services/staged_dataset_service.py | Implemented service for managing staged dataset files and metadata |
| application/backend/app/services/init.py | Exported StagedDatasetService from services module |
| application/backend/app/models/dataset.py | Added DatasetFormat enum and StagedDataset model |
| application/backend/app/models/init.py | Exported dataset models from models module |
| application/backend/app/api/schemas/dataset.py | Added model validator to populate StagedDatasetView from StagedDataset |
| application/backend/app/api/routers/dataset_ie.py | Implemented REST API endpoints for staged dataset operations |
| application/backend/app/api/io_utils.py | Added file_iterator utility for streaming file responses |
| application/backend/app/api/dependencies.py | Added dependency injection for StagedDatasetService |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📊 Test coverage report
|
Docker Image SizesCPU
GPU
XPU
|
leoll2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small comments, LGTM overall
Summary
Checklist