-
Notifications
You must be signed in to change notification settings - Fork 462
[WIP] Implement job to export dataset #5443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors job implementations into an executor pattern and adds dataset export functionality with comprehensive BDD testing.
Changes:
- Refactored job implementations from a
Trainerbase class to a more genericExecutorbase class - Added dataset export job with support for COCO, YOLO, and DATUMARO_V2 formats
- Implemented BDD tests using behave framework for dataset export scenarios
Reviewed changes
Copilot reviewed 50 out of 57 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| application/backend/app/executors/base.py | Renamed Trainer to Executor and removed training-specific logic |
| application/backend/app/executors/dataset_export/exporter.py | New dataset exporter implementation with multi-format support |
| application/backend/app/models/jobs/export_dataset_job.py | New job model for dataset export operations |
| application/backend/app/api/routers/jobs.py | Added endpoint handling for dataset export job submission |
| application/backend/app/lifecycle.py | Registered dataset exporter in job controller factory |
| application/backend/tests/bdd/ | BDD test infrastructure and dataset export scenarios |
| application/backend/app/repositories/filters.py | Extracted common filter logic for reuse |
| application/backend/app/models/dataset_item.py | Added REVIEWED_WITH_UNANNOTATED annotation status |
| .github/workflows/backend-lint-and-test.yaml | Added BDD test execution step |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8ff6903 to
a360e22
Compare
📊 Test coverage report
|
Docker Image SizesCPU
GPU
XPU
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
51d5452 to
4963b12
Compare
…onverter & introduce factories per sample type + add more bdd tests for export dataset
4963b12 to
b1ae52b
Compare
Summary
Checklist