Skip to content

Conversation

@itallix
Copy link
Contributor

@itallix itallix commented Feb 9, 2026

Summary

  • Streaming endpoint gets full log for jobs in terminal status
  • Added a new endpoint to retrieve model logs

Checklist

  • The PR title and description are clear and descriptive
  • I have manually tested the changes
  • All changes are covered by automated tests
  • All related issues are linked to this PR (if applicable)
  • Documentation has been updated (if applicable)

@itallix itallix requested a review from a team as a code owner February 9, 2026 12:14
Copilot AI review requested due to automatic review settings February 9, 2026 12:14
@itallix itallix linked an issue Feb 9, 2026 that may be closed by this pull request
@github-actions github-actions bot added TEST Any changes in tests Geti Tune Backend Issues related to Geti Tune backend labels Feb 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for retrieving model training logs via a new API endpoint and adjusts job log streaming behavior to allow streaming logs for terminal jobs.

Changes:

  • Added GET /api/projects/{project_id}/models/{model_id}/logs endpoint backed by ModelService.get_logs().
  • Updated job log streaming behavior and refactored streaming test helpers.
  • Added unit/integration tests covering model-log retrieval and job-log streaming for completed jobs.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
application/backend/app/services/model_service.py Adds get_logs() to locate and validate availability of model training logs.
application/backend/app/api/routers/models.py Introduces a new route returning log files via FileResponse.
application/backend/app/api/routers/jobs.py Changes streaming logic so terminal jobs can still stream logs, but modifies stop conditions.
application/backend/tests/unit/routers/test_models.py Adds unit tests for the new model logs endpoint.
application/backend/tests/unit/routers/test_jobs.py Refactors streaming test helper and updates expectations for completed-job log streaming.
application/backend/tests/integration/services/test_model_service.py Adds integration tests for ModelService.get_logs() across statuses and missing files.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

📊 Test coverage report

Metric Coverage
Lines 34.6%
Functions 73.8%
Branches 88.3%
Statements 34.6%

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Docker Image Sizes

CPU

Image Size
geti-tune-cpu:pr-5469 2.97G
geti-tune-cpu:sha-9c163e4 2.97G

GPU

Image Size
geti-tune-gpu:pr-5469 10.95G
geti-tune-gpu:sha-9c163e4 10.95G

XPU

Image Size
geti-tune-xpu:pr-5469 9.76G
geti-tune-xpu:sha-9c163e4 9.76G

@itallix itallix force-pushed the vitalii/5452-model-logs-endpoint branch from 61e2045 to 2989921 Compare February 9, 2026 12:38
@itallix itallix added this pull request to the merge queue Feb 9, 2026
Merged via the queue into develop with commit b3e3d2a Feb 9, 2026
32 checks passed
@itallix itallix deleted the vitalii/5452-model-logs-endpoint branch February 9, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Geti Tune Backend Issues related to Geti Tune backend TEST Any changes in tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement endpoint to retrieve model logs

2 participants