A few more component tests for model-details #5475
Merged
+269
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Adds coverage for the model-details view (model variants + training datasets) and centralizes model-architectures MSW mocking for UI tests.
Changes:
- Introduces a new
model-details.spec.tssuite covering variants and training dataset states. - Moves
/api/model_architecturesmocking into the shared Playwright fixtures (removing per-spec duplication). - Improves tab accessibility selectors by adding
aria-labels to model variant tabs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| application/ui/tests/models/models.spec.ts | Removes model-architectures mocking from this spec and slightly renames a test. |
| application/ui/tests/models/model-details.spec.ts | Adds new component/e2e-like tests for model details: variants + training datasets. |
| application/ui/tests/jobs/jobs.spec.ts | Removes model-architectures mocking from this spec. |
| application/ui/tests/fixtures.ts | Centralizes /api/model_architectures MSW handler for all UI tests. |
| application/ui/src/features/models/model-listing/model-variants/model-variant-tabs.component.tsx | Adds aria-label to icon-only variant tabs to support accessible queries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ication/ui/src/features/models/model-listing/model-variants/model-variant-tabs.component.tsx
Show resolved
Hide resolved
📊 Test coverage report
|
Docker Image SizesCPU
GPU
XPU
|
dwesolow
reviewed
Feb 9, 2026
dwesolow
reviewed
Feb 9, 2026
dwesolow
reviewed
Feb 9, 2026
dwesolow
reviewed
Feb 9, 2026
dwesolow
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How to test
Checklist