Skip to content

Conversation

@jpggvilaca
Copy link
Contributor

Summary

Screenshot 2026-02-09 at 15 31 56 Screenshot 2026-02-09 at 16 12 48 Screenshot 2026-02-09 at 16 17 43

How to test

Checklist

  • The PR title and description are clear and descriptive
  • I have manually tested the changes
  • All changes are covered by automated tests
  • All related issues are linked to this PR (if applicable)
  • Documentation has been updated (if applicable)

@jpggvilaca jpggvilaca requested a review from a team as a code owner February 9, 2026 15:18
Copilot AI review requested due to automatic review settings February 9, 2026 15:18
@jpggvilaca jpggvilaca added the Geti Tune UI Issues related to Geti Tune UI label Feb 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the training and annotation UX by surfacing more guidance to users (dataset selection help, training prerequisites warning) and improving discoverability via tooltips.

Changes:

  • Moves “not enough annotated items” feedback from disabling the “Train model” button to an in-dialog warning.
  • Renames/clarifies dataset revision selection (“Use current dataset”) and adds contextual help for dataset selection.
  • Adds/adjusts tooltip placements in the annotator and dataset preview toolbars.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
application/ui/src/features/models/train-model/train-model.component.tsx Allows opening the training dialog regardless of dataset annotation count (no longer disables the trigger button).
application/ui/src/features/models/train-model/train-model.component.test.tsx Updates tests to assert the new in-dialog warning behavior instead of button disabled state.
application/ui/src/features/models/train-model/train-model-provider.component.tsx Updates dataset option label to “Use current dataset”.
application/ui/src/features/models/train-model/train-model-dialog.component.tsx Adds an InlineAlert explaining why training can’t start and refactors footer layout.
application/ui/src/features/models/train-model/select-dataset-revision.component.tsx Renames label to “Select dataset” and adds contextual help explaining dataset vs revision behavior.
application/ui/src/features/dataset/media-preview/primary-toolbar/toggle-annotations-visibility.component.tsx Sets tooltip placement to the right for the annotations visibility toggle.
application/ui/src/features/annotator/tools/tools.component.tsx Adds right-placed tooltips showing tool name and hotkey.
Comments suppressed due to low confidence (1)

application/ui/src/features/annotator/tools/tools.component.tsx:25

  • This looks like an icon-only ActionButton (the visible content is an icon). Tooltips don’t reliably provide accessible names for screen readers, so the button should have an accessible label (e.g., aria-label={tool.label} or similar) to ensure it’s usable with assistive tech.
            <ActionButton
                isQuiet
                width={'size-400'}
                onPress={() => setActiveTool(tool.type)}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

📊 Test coverage report

Metric Coverage
Lines 36.5%
Functions 76.8%
Branches 88.0%
Statements 36.5%

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Docker Image Sizes

CPU

Image Size
geti-tune-cpu:pr-5477 2.97G
geti-tune-cpu:sha-2461f9c 2.97G

GPU

Image Size
geti-tune-gpu:pr-5477 10.95G
geti-tune-gpu:sha-2461f9c 10.95G

XPU

Image Size
geti-tune-xpu:pr-5477 9.76G
geti-tune-xpu:sha-2461f9c 9.76G

>
{(item) => <Item key={item.id}>{item.name}</Item>}
</Picker>
<>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np. fragment not needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will get rid of it on the next one

@jpggvilaca jpggvilaca added this pull request to the merge queue Feb 10, 2026
Merged via the queue into develop with commit 52c3fb6 Feb 10, 2026
31 checks passed
@jpggvilaca jpggvilaca deleted the jvilaca/user-help branch February 10, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Geti Tune UI Issues related to Geti Tune UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants