-
Notifications
You must be signed in to change notification settings - Fork 462
Add some user information #5477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates the training and annotation UX by surfacing more guidance to users (dataset selection help, training prerequisites warning) and improving discoverability via tooltips.
Changes:
- Moves “not enough annotated items” feedback from disabling the “Train model” button to an in-dialog warning.
- Renames/clarifies dataset revision selection (“Use current dataset”) and adds contextual help for dataset selection.
- Adds/adjusts tooltip placements in the annotator and dataset preview toolbars.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| application/ui/src/features/models/train-model/train-model.component.tsx | Allows opening the training dialog regardless of dataset annotation count (no longer disables the trigger button). |
| application/ui/src/features/models/train-model/train-model.component.test.tsx | Updates tests to assert the new in-dialog warning behavior instead of button disabled state. |
| application/ui/src/features/models/train-model/train-model-provider.component.tsx | Updates dataset option label to “Use current dataset”. |
| application/ui/src/features/models/train-model/train-model-dialog.component.tsx | Adds an InlineAlert explaining why training can’t start and refactors footer layout. |
| application/ui/src/features/models/train-model/select-dataset-revision.component.tsx | Renames label to “Select dataset” and adds contextual help explaining dataset vs revision behavior. |
| application/ui/src/features/dataset/media-preview/primary-toolbar/toggle-annotations-visibility.component.tsx | Sets tooltip placement to the right for the annotations visibility toggle. |
| application/ui/src/features/annotator/tools/tools.component.tsx | Adds right-placed tooltips showing tool name and hotkey. |
Comments suppressed due to low confidence (1)
application/ui/src/features/annotator/tools/tools.component.tsx:25
- This looks like an icon-only
ActionButton(the visible content is an icon). Tooltips don’t reliably provide accessible names for screen readers, so the button should have an accessible label (e.g.,aria-label={tool.label}or similar) to ensure it’s usable with assistive tech.
<ActionButton
isQuiet
width={'size-400'}
onPress={() => setActiveTool(tool.type)}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
application/ui/src/features/models/train-model/train-model-dialog.component.tsx
Outdated
Show resolved
Hide resolved
application/ui/src/features/models/train-model/train-model-dialog.component.tsx
Outdated
Show resolved
Hide resolved
application/ui/src/features/models/train-model/train-model-dialog.component.tsx
Outdated
Show resolved
Hide resolved
application/ui/src/features/models/train-model/train-model.component.test.tsx
Show resolved
Hide resolved
📊 Test coverage report
|
Docker Image SizesCPU
GPU
XPU
|
application/ui/src/features/models/train-model/select-dataset-revision.component.tsx
Outdated
Show resolved
Hide resolved
application/ui/src/features/models/train-model/train-model-dialog.component.tsx
Show resolved
Hide resolved
application/ui/src/features/models/train-model/select-dataset-revision.component.tsx
Outdated
Show resolved
Hide resolved
application/ui/src/features/models/train-model/select-dataset-revision.component.tsx
Outdated
Show resolved
Hide resolved
| > | ||
| {(item) => <Item key={item.id}>{item.name}</Item>} | ||
| </Picker> | ||
| <> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np. fragment not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will get rid of it on the next one
Summary
How to test
Checklist