Skip to content

WIP: Generate and deploy to Netlify in CI #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

srid
Copy link
Contributor

@srid srid commented Jan 22, 2020

[Includes #8]

Just playing with it in the interest of srid/rib#93

Not ready to be merged yet.

@srid
Copy link
Contributor Author

srid commented Jan 22, 2020

Seems to have done something though I'm not sure where exactly it deployed it, if at all ...
image

@srid
Copy link
Contributor Author

srid commented Jan 22, 2020

Okay, now it says "Deploying" - but nothing comes after:

image

@srid
Copy link
Contributor Author

srid commented Jan 22, 2020

@JonathanReeve Any idea about this "Mixed content" error from Netlify? https://github.com/open-editions/open-editions.org/runs/403388638

@srid
Copy link
Contributor Author

srid commented Jan 22, 2020

Okay, the cli action seems to work. Though it requires credentials set on this repo I guess:

image

@srid srid mentioned this pull request Jan 22, 2020
@srid srid changed the title WIP: Generate and deploy to Netify in CI WIP: Generate and deploy to Netlify in CI Jan 22, 2020
@JonathanReeve
Copy link
Member

Awesome. Do I just add auth environment variables via Settings -> Secrets, for this repo?

@JonathanReeve
Copy link
Member

I added secrets, so I think I should be able to try merging this once it's not a draft.

@srid
Copy link
Contributor Author

srid commented Jan 22, 2020

I'm using this blog post as a reference, which does talk about adding secret keys to the repo.

I pushed a new commit to trigger the build, but the deploy step seems to be stuck ... hmm ....

@JonathanReeve
Copy link
Member

It looks like it's just missing the auth details? Now that I added them, it should work, I imagine. I just triggered a rebuild just now, so we'll see.

@srid
Copy link
Contributor Author

srid commented Jan 29, 2020

It tries to open the web browser and fails:

Opening https://app.netlify.com/authorize?response_type=ticket&ticket=f7d8632091e84532a739eb0af35df741
---------------------------
Error: Unable to open browser automatically

Please open your browser & open the URL below to login:
https://app.netlify.com/authorize?response_type=ticket&ticket=f7d8632091e84532a739eb0af35df741
---------------------------
TimeoutError: Promise timed out after 3600000 milliseconds
    at Timeout.setTimeout [as _onTimeout] (/usr/local/share/.config/yarn/global/node_modules/p-timeout/index.js:27:54)

I think there is something we are not doing right. I have other things to do right now, so my efforts on srid/rib#93 may have to wait a bit.

@JonathanReeve
Copy link
Member

I got this to work, kind of, through a kind of dirty hack where I compile to the gh-pages branch, and then get Netlify to serve that branch. It works OK for now, so I'll close this PR, but if you have any ideas about how to streamline this action, or speed it up, please let me know. What would be really nice is to do something like -uses: srid/compile-with-rib-action that wraps up all these steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants