assignments: Introduce mini-libc assignment #209

razvand · 2023-03-20T19:03:52Z

Mini-libc is a minimalistic standard C library (libc) implementation. It is meant to be used as a complete replacement for the system libc (glibc in Linux). This is why test programs are built with -nostinc, -nostlib, -fno-builtin options.

The actual library source code is part of the libc/ directory. It is to be compiled as a static library in the libc.a file.

A set of sample use cases, as C source files, are stored in the samples/ directory.

Tests are in the tests/ directory, both as source code and shell scripts.

The aim is to have a minimally functional libc with features such as:

string management
very basic memory support
POSIX file I/O (i.e. open(), read(), write())
basic printing (puts())
sleep functions

Alex-deVis

I left a few suggestions for the prompt of bash commands.

assignments/mini-libc/README.md

assignments/mini-libc/libc/include/stdlib.h

assignments/mini-libc/libc/include/string.h

assignments/mini-libc/libc/include/sys/mman.h

assignments/mini-libc/libc/include/sys/stat.h

assignments/mini-libc/libc/include/unistd.h

assignments/mini-libc/libc/io/close.c

assignments/mini-libc/libc/io/truncate.c

assignments/mini-libc/libc/mm/malloc.c

assignments/mini-libc/libc/stat/fstat.c

assignments/mini-libc/samples/buffered_io.c

assignments/mini-libc/libc/Makefile

assignments/mini-libc/tests/test_io.c

assignments/mini-libc/samples/Makefile

assignments/mini-libc/libc/Makefile

assignments/mini-libc/libc/include/sys/stat.h

assignments/mini-libc/tests/test_io.c

teodutu

At first glance, things look good enough. The suggested changes are purely cosmetic, so focus on merging this ASAP.

content/assignments/mini-libc/README.md

content/assignments/mini-libc/libc/include/internal/types.h

content/assignments/mini-libc/tests/memory/malloc.c

content/assignments/mini-libc/tests/io/stat.c

pufi656 · 2023-03-24T05:39:42Z

content/assignments/mini-libc/tests/test_malloc.sh

+    fi
+
+    "$exec_file" &
+    PID=$!


Also, I noticed that without an extra sleep less than 1 second added here (to account for the 1s sleep in the source file), the behaviour is unexpected, generating different results on different runs, not sure if it is a problem only on my end but the extra sleep generates a stable response on multiple runs

this was also what I noticed.

@pufi656, @JunisvaultCo, I now understand the issue. Will be back with a fix, please then let me know if it works on your side.

@razvand, can't it be also improved by using interruption signals?

@pufi656, @JunisvaultCo, please see if the updated version works for you.

@pufi656, what about the othe malloc / mmap scripts?

@razvand, I've checked with latest changes from this pr an right now only these 2 tests are failing:

test_multiple_malloc_free ........................ failed ... 0 test_malloc_free_sequence ........................ failed ... 0

I will check what is the cause, but probably the same.

Nvm, everything seems to be working fine, I should clean the remotes and check again.

@razvand confirming all scripts regarding memory testing work fine

confirmed as well

molecula2788

Looks ok to me, only minor changes.

content/assignments/mini-libc/tests/test_stat.sh

content/assignments/mini-libc/tests/memory/mmap_perm_none.c

content/assignments/mini-libc/samples/open_close.c

content/assignments/mini-libc/tests/memory/malloc.c

content/assignments/mini-libc/samples/truncate_ftruncate.c

content/assignments/mini-libc/samples/stat.c

content/assignments/mini-libc/samples/fstat.c

Mini-libc is a minimalistic standard C library (libc) implementation. It is meant to be used as a complete replacement for the system libc (glibc in Linux). This is why test programs are built with `-nostinc`, `-nostlib`, `-fno-builtin` options. The actual library source code is part of the `libc/` directory. It is to be compiled as a static library in the `libc.a` file. A set of sample use cases, as C source files, are stored in the `samples/` directory. Tests are in the `tests/` directory, both as source code and shell scripts. The aim is to have a minimally functional libc with features such as: - string management - very basic memory support - POSIX file I/O (i.e. `open()`, `read()`, `write()`) - basic printing (`puts()`) - sleep functions Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro> Signed-off-by: Ruxandra Grigorie <ruxi.grigorie@gmail.com> Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com> Signed-off-by: Adrian Șendroiu <molecula2788@gmail.com> Signed-off-by: Gabriel Mocanu <gabi.mocanu98@gmail.com> Signed-off-by: Alexandru Apostolescu <alexx.apostolescu@gmail.com> Signed-off-by: Alex-Costin Puflene <alexpufi22@yahoo.com> Signed-off-by: Vlad Tiftilov <vlad.tiftilov@yahoo.com> Signed-off-by: Laurențiu Ursu <laurentiu.ursu2001@gmail.com> Signed-off-by: Iulia-Silvia Plăiașu <isplaiasu@gmail.com>

razvand added kind/new New content / item topic/software-stack Related to "Software Stack" chapter area/assignment Update to homework assignments labels Mar 20, 2023

razvand added this to the SO 2022-2023 sem 2 milestone Mar 20, 2023

razvand requested review from molecula2788 and gabrielmocanu March 20, 2023 19:03

razvand assigned teodutu Mar 20, 2023

razvand force-pushed the assignment-mini-libc branch from 4322d7b to 8282c23 Compare March 20, 2023 19:04

Alex-deVis approved these changes Mar 20, 2023

View reviewed changes

assignments/mini-libc/README.md Outdated Show resolved Hide resolved

assignments/mini-libc/README.md Outdated Show resolved Hide resolved

assignments/mini-libc/README.md Outdated Show resolved Hide resolved

razvand force-pushed the assignment-mini-libc branch from 8282c23 to f7afeda Compare March 20, 2023 19:30

gabrielmocanu requested changes Mar 20, 2023

View reviewed changes

gabrielmocanu requested changes Mar 21, 2023

View reviewed changes

assignments/mini-libc/libc/Makefile Outdated Show resolved Hide resolved

vladtf reviewed Mar 21, 2023

View reviewed changes

assignments/mini-libc/tests/test_io.c Outdated Show resolved Hide resolved

vladtf reviewed Mar 21, 2023

View reviewed changes

assignments/mini-libc/samples/Makefile Outdated Show resolved Hide resolved

vladtf reviewed Mar 21, 2023

View reviewed changes

assignments/mini-libc/libc/Makefile Outdated Show resolved Hide resolved

vladtf reviewed Mar 21, 2023

View reviewed changes

assignments/mini-libc/libc/include/sys/stat.h Outdated Show resolved Hide resolved

StefanJum reviewed Mar 22, 2023

View reviewed changes

assignments/mini-libc/tests/test_io.c Outdated Show resolved Hide resolved

This comment was marked as spam.

Sign in to view

This comment was marked as off-topic.

Sign in to view

razvand force-pushed the assignment-mini-libc branch from 05afe62 to 2ab673a Compare March 24, 2023 00:40

razvand requested review from teodutu, gabrielmocanu and RuxG March 24, 2023 00:40

razvand force-pushed the assignment-mini-libc branch from 8bd8d6b to 637fb7e Compare March 24, 2023 01:10

teodutu approved these changes Mar 24, 2023

View reviewed changes

pufi656 reviewed Mar 24, 2023

View reviewed changes

content/assignments/mini-libc/tests/io/stat.c Outdated Show resolved Hide resolved

pufi656 reviewed Mar 24, 2023

View reviewed changes

razvand force-pushed the assignment-mini-libc branch from c8828d6 to 46fa63d Compare March 24, 2023 10:09

molecula2788 approved these changes Mar 24, 2023

View reviewed changes

content/assignments/mini-libc/tests/test_stat.sh Outdated Show resolved Hide resolved

content/assignments/mini-libc/tests/memory/mmap_perm_none.c Show resolved Hide resolved

gabrielmocanu requested changes Mar 24, 2023

View reviewed changes

razvand requested a review from gabrielmocanu March 24, 2023 12:01

gabrielmocanu approved these changes Mar 24, 2023

View reviewed changes

razvand force-pushed the assignment-mini-libc branch from aea89b6 to 8a06acb Compare March 24, 2023 12:35

razvand force-pushed the assignment-mini-libc branch from 8a06acb to e085bb0 Compare March 24, 2023 12:43

razvand merged commit d01ab62 into open-education-hub:master Mar 24, 2023

razvand deleted the assignment-mini-libc branch March 24, 2023 17:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

assignments: Introduce mini-libc assignment #209

assignments: Introduce mini-libc assignment #209

razvand commented Mar 20, 2023

Alex-deVis left a comment

This comment was marked as spam.

This comment was marked as off-topic.

teodutu left a comment

pufi656 Mar 24, 2023

JunisvaultCo Mar 24, 2023

razvand Mar 24, 2023

vladtf Mar 24, 2023

razvand Mar 24, 2023

razvand Mar 24, 2023

vladtf Mar 24, 2023 •

edited

Loading

vladtf Mar 24, 2023

pufi656 Mar 24, 2023

JunisvaultCo Mar 24, 2023

molecula2788 left a comment

assignments: Introduce mini-libc assignment #209

assignments: Introduce mini-libc assignment #209

Conversation

razvand commented Mar 20, 2023

Alex-deVis left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as off-topic.

teodutu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vladtf Mar 24, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

molecula2788 left a comment

Choose a reason for hiding this comment

vladtf Mar 24, 2023 •

edited

Loading