Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinguish between Device Group & Device properties #223

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Distinguish between Device Group & Device properties #223

wants to merge 3 commits into from

Conversation

cjsha
Copy link
Member

@cjsha cjsha commented Feb 27, 2025 •
edited
Loading

Previous discussion in #174. I created this new branch issue-171-clean from issue-171 because the merge conflicts were more annoying to resolve than doing this.

  • The title refers to work done on the OpenEphys.Onix1 overview page
  • "Aggregate", "Multi-Device" -> "Device Group" throughout the docs
  • Add css classes for badges
  • Define what devices are in api/configure.md and api/device-configure.md
  • I wanted to link to properties in the tables which motivated me to fix the xref issue Property xref should go to property #70. That's what the changes are related to in the .js files are concerning.
  • Reduce excessive formatting (specifically hyperlinks don't need to be wrapped in back ticks)
  • Remove comments that appear in HTML inspector

Resolve #171
Resolve #70

@cjsha
Distinguish between aggregate & device properties
39f632c 
- This is done on the OpenEphys.Onix1 overview page
- "Aggregate", "Multi-Device" -> "Device Group"
- Add css classes for badges
- Define what devices are on the configuration operator pages
- I wanted to link to properties in the tables which motivated me to fix the xref issue #70. This fix seems to work well enough for now. That's what the changes are related to in the .js files are concerning.
- Reduce excessive formatting (specifically hyperlinks don't need to be wrapped in back ticks)
- Remove comments that appear in HTML inspector
@cjsha cjsha requested a review from jonnew February 27, 2025 19:03
@cjsha cjsha mentioned this pull request Feb 27, 2025
Closed
cjsha and others added 2 commits February 27, 2025 14:19
@cjsha
Fix broken reference
b65361e
@jonnew
Review property description PR
fbb9d2d 
- Some edits to descriptions and page layout
- Add image of property pane
jonnew
jonnew approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@jonnew jonnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some changes, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnew jonnew jonnew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistancy in Devices versus acquisition, and configuration tags Property xref should go to property
2 participants
@cjsha @jonnew