Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
- Removed "Probe A/B" from dialog when opening 1.0f probes
- Changed the Refresh symbol to a Warning symbol
- Allow the status strip labels to auto size, so the text doesn't get cut off
  • Loading branch information
bparks13 committed Oct 8, 2024
1 parent cea6b89 commit 4d99f1d
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 24 deletions.
11 changes: 0 additions & 11 deletions OpenEphys.Onix1.Design/NeuropixelsV1Dialog.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ public NeuropixelsV1Dialog(IConfigureNeuropixelsV1 configureNode)
else if (configureNode is ConfigureNeuropixelsV1f configureV1f)
{
ConfigureNode = new ConfigureNeuropixelsV1f(configureV1f);
Text += ": " + GetProbeName(configureV1f.ProbeName);
}

ProbeConfigurationDialog = new(ConfigureNode.ProbeConfiguration, ConfigureNode.AdcCalibrationFile, ConfigureNode.GainCalibrationFile)
Expand All @@ -48,16 +47,6 @@ public NeuropixelsV1Dialog(IConfigureNeuropixelsV1 configureNode)
this.AddMenuItemsFromDialogToFileOption(ProbeConfigurationDialog);
}

private string GetProbeName(NeuropixelsV1Probe probe)
{
return probe switch
{
NeuropixelsV1Probe.ProbeA => "Probe A",
NeuropixelsV1Probe.ProbeB => "Probe B",
_ => "Invalid probe was specified."
};
}

private void FormShown(object sender, EventArgs e)
{
if (!TopLevel)
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ private void CheckStatus()

if (toolStripAdcCalSN.Text == NoFileSelected || toolStripGainCalSN.Text == NoFileSelected)
{
toolStripStatus.Image = Properties.Resources.StatusRefreshImage;
toolStripStatus.Image = Properties.Resources.StatusWarningImage;
toolStripStatus.Text = "Select files.";
}
else if (toolStripAdcCalSN.Text == InvalidFile || toolStripGainCalSN.Text == InvalidFile)
Expand Down

0 comments on commit 4d99f1d

Please sign in to comment.