Add GUI for Neuropixels V1e #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure reference contacts are correctly highlighted - Update adc/gain calibration file parsing - Fix anchors for controls to allow resizing more fluidly - Add icons to dialogs - Add zoom in boundary - Reduce scale bar thickness - Fix splitter panel distance
- Until we can properly validate files using a schema, we cannot parse the calibration files using the GUI as any exceptions cause the dialog to crash
|
We will need to bring the changes from #243 into this PR, I suppose. |
|
@jonnew actually we won't need to, the scaling issues occurred at the device/headstage level, not the common framework level. Meaning, I was able to fix the |
- Make labels uniform - Tool tips on NP1.0 and uniform messages - Uniform look and feel (background color, track bar)
|
@bparks13 I made some minor changes to make the NP GUIs more uniform. Once you confirm I have not broken anything, lets merge this. |
jonnew
approved these changes
Aug 22, 2024
- A panel was removed, but the relevant code was left in place, leading to build errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add a dialog GUI for the
NeuropixelsV1eheadstage.Controls are based on
NeuropixelsV2eGUI, for more info on the controls see #214.One major difference between V1 and V2 is that V1 has two separate calibration files that are required (Gain and ADC). The probe will not be visible unless both files exist and are selected.
Closes #106