Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve StartAqcuisition documentation #278

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Improve StartAqcuisition documentation #278

merged 2 commits into from
Sep 4, 2024

Conversation

jonnew
Copy link
Member

@jonnew jonnew commented Sep 3, 2024

@jonnew
Improve StartAqcuisition documentation
f1ba733 
- Add details to class description about what the operator does and what
  it produces without cref links to clroni
- Fix typo in BitHelper
@jonnew jonnew added this to the 0.3.0 milestone Sep 3, 2024
@jonnew jonnew requested a review from cjsha September 3, 2024 14:29
cjsha
cjsha approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@cjsha cjsha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved but please go through and consider all the comments - I'm not sure it requires another review cycle after you address them (though you can re-request me if you want)

OpenEphys.Onix1/StartAcquisition.cs Outdated Show resolved Hide resolved
OpenEphys.Onix1/StartAcquisition.cs Outdated Show resolved Hide resolved
OpenEphys.Onix1/StartAcquisition.cs Outdated Show resolved Hide resolved
OpenEphys.Onix1/StartAcquisition.cs Outdated Show resolved Hide resolved
OpenEphys.Onix1/StartAcquisition.cs Outdated Show resolved Hide resolved
OpenEphys.Onix1/StartAcquisition.cs Outdated Show resolved Hide resolved
OpenEphys.Onix1/StartAcquisition.cs Outdated Show resolved Hide resolved
@jonnew jonnew merged commit cb6df3e into main Sep 4, 2024
7 checks passed
@jonnew jonnew deleted the issue-263 branch September 4, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjsha cjsha cjsha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Improve StartAcqusition explaination
2 participants
@jonnew @cjsha