Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine all polled Bno055 classes into common type #303

Merged
merged 3 commits into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions OpenEphys.Onix1.Design/Bno055Dialog.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ private void FormShown(object sender, EventArgs e)
{
if (!TopLevel)
{
splitContainer1.Panel2Collapsed = true;
splitContainer1.Panel2.Hide();
tableLayoutPanel1.Controls.Remove(flowLayoutPanel1);
tableLayoutPanel1.RowCount = 1;

MaximumSize = new System.Drawing.Size(0, 0);
}
Expand Down
2 changes: 2 additions & 0 deletions OpenEphys.Onix1.Design/Bno055Editor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ public override bool EditComponent(ITypeDescriptorContext context, object compon
if (editorDialog.ShowDialog() == DialogResult.OK)
{
configureBno055.Enable = editorDialog.ConfigureNode.Enable;
configureBno055.DeviceAddress = editorDialog.ConfigureNode.DeviceAddress;
configureBno055.DeviceName = editorDialog.ConfigureNode.DeviceName;

return true;
}
Expand Down
82 changes: 42 additions & 40 deletions OpenEphys.Onix1.Design/GenericDeviceDialog.Designer.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

42 changes: 0 additions & 42 deletions OpenEphys.Onix1.Design/NeuropixelsV1eBno055Dialog.cs

This file was deleted.

10 changes: 5 additions & 5 deletions OpenEphys.Onix1.Design/NeuropixelsV1eHeadstageDialog.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace OpenEphys.Onix1.Design
/// </summary>
/// <remarks>
/// Within the GUI, there is a tab for both devices encapsulated by a <see cref="ConfigureNeuropixelsV1eHeadstage"/>,
/// specifically a <see cref="ConfigureNeuropixelsV1e"/> and a <see cref="ConfigureNeuropixelsV1eBno055"/>.
/// specifically a <see cref="ConfigureNeuropixelsV1e"/> and a <see cref="ConfigurePolledBno055"/>.
/// </remarks>
public partial class NeuropixelsV1eHeadstageDialog : Form
{
Expand All @@ -17,16 +17,16 @@ public partial class NeuropixelsV1eHeadstageDialog : Form
public readonly NeuropixelsV1eDialog DialogNeuropixelsV1e;

/// <summary>
/// Public method that provides access to the <see cref="NeuropixelsV1eBno055Dialog"/>.
/// Public method that provides access to the <see cref="PolledBno055Dialog"/>.
/// </summary>
public readonly NeuropixelsV1eBno055Dialog DialogBno055;
public readonly PolledBno055Dialog DialogBno055;

/// <summary>
/// Initializes a new instance of a <see cref="NeuropixelsV1eHeadstageDialog"/>.
/// </summary>
/// <param name="configureNeuropixelsV1e">Configuration settings for a <see cref="ConfigureNeuropixelsV1e"/>.</param>
/// <param name="configureBno055">Configuration settings for a <see cref="ConfigureNeuropixelsV1eBno055"/>.</param>
public NeuropixelsV1eHeadstageDialog(ConfigureNeuropixelsV1e configureNeuropixelsV1e, ConfigureNeuropixelsV1eBno055 configureBno055)
/// <param name="configureBno055">Configuration settings for a <see cref="ConfigurePolledBno055"/>.</param>
public NeuropixelsV1eHeadstageDialog(ConfigureNeuropixelsV1e configureNeuropixelsV1e, ConfigurePolledBno055 configureBno055)
{
InitializeComponent();

Expand Down
39 changes: 0 additions & 39 deletions OpenEphys.Onix1.Design/NeuropixelsV2eBno055Dialog.Designer.cs

This file was deleted.

42 changes: 0 additions & 42 deletions OpenEphys.Onix1.Design/NeuropixelsV2eBno055Dialog.cs

This file was deleted.

35 changes: 0 additions & 35 deletions OpenEphys.Onix1.Design/NeuropixelsV2eBno055Editor.cs

This file was deleted.

8 changes: 4 additions & 4 deletions OpenEphys.Onix1.Design/NeuropixelsV2eHeadstageDialog.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,16 @@ public partial class NeuropixelsV2eHeadstageDialog : Form
public readonly NeuropixelsV2eDialog DialogNeuropixelsV2e;

/// <summary>
/// A <see cref="NeuropixelsV2eBno055Dialog"/> that configures a <see cref="ConfigureNeuropixelsV2eBno055"/>.
/// A <see cref="PolledBno055Dialog"/> that configures a <see cref="ConfigurePolledBno055"/>.
/// </summary>
public readonly NeuropixelsV2eBno055Dialog DialogBno055;
public readonly PolledBno055Dialog DialogBno055;

/// <summary>
/// Initializes a new instance of a <see cref="NeuropixelsV2eHeadstageDialog"/>.
/// </summary>
/// <param name="configureNeuropixelsV2e">Configuration settings for a <see cref="ConfigureNeuropixelsV2e"/>.</param>
/// <param name="configureBno055">Configuration settings for a <see cref="ConfigureNeuropixelsV2eBno055"/>.</param>
public NeuropixelsV2eHeadstageDialog(IConfigureNeuropixelsV2 configureNeuropixelsV2e, ConfigureNeuropixelsV2eBno055 configureBno055)
/// <param name="configureBno055">Configuration settings for a <see cref="ConfigurePolledBno055"/>.</param>
public NeuropixelsV2eHeadstageDialog(IConfigureNeuropixelsV2 configureNeuropixelsV2e, ConfigurePolledBno055 configureBno055)
{
InitializeComponent();

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading