Functional onix-headstage-neuropix1 support #315
Conversation
jonnew
commented
Sep 29, 2024
jonnew
commented
- Needs XML docs
- Needs GUI integration
- Needs testing with more than one probe
- Needs XML docs - Needs GUI integration - Needs testing with more than one probe
|
- Fix error in applicaiton of gain correction values - Common NeuropixelsV1Frame for e and f variants - Common IConfigureNeuropixelsV1 interface for eventual unified GUI support for both e and f headstage variants - Add XML commonets to f variants
- Made NeuropixelsV1 dialogs more generalized, so they can be shared between V1e and V1f - Added V1 Probe Configuration to match V2 to aid in modularity of dialogs
|
It seems like there is a little left over icon at the bottom of the GUI still: 
|
|
When i run the GUI on a 
I dont think that should be there because the A vs. B is given by the device address in this case. Basically, nothing needs to change compared to the |
|
@jonnew The icon is supposed to be there, it indicates if the calibration files are valid, and if the serial numbers of the files match. This does not touch hardware, but is meant as an easy way to see which files are currently loaded and if they match. However, the text is being cut off, which is incorrect, so that needs to be fixed. |
|
When I see the circle arrow icon, I expect to be able to click it to refresh, but that does not seem to be the case here. I would be a yellow warning triagle or something to indicate that cal files are needed |
- Removed "Probe A/B" from dialog when opening 1.0f probes - Changed the Refresh symbol to a Warning symbol - Allow the status strip labels to auto size, so the text doesn't get cut off
|
Last critique. I think changing this: 
to this: 
would be more clear. I deleted the colons, but those should stay. |
|
Looks good now, however, the NP2.0 GUIs show this: 
it would be nice if it had the same look as NP1.0: 
|
- This is to match the look and feel of the 1.0 dialog status strip
|
@jonnew the 2.0 dialogs have been updated to match these changes to 1.0 |
