Reduced I2C clock when talking to atMega on miniscope #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonnew
commented
Oct 18, 2024
jonnew
commented
- Only set reduced (80 kHz) I2C clock when talking to the atMega, which has a bit-banged implementation
- For the rest of the chips, reset to to 200 kHz, which seems to provide max sampling on BNO while maintaining reliability
- Fixes Can miniscope i2c be switched to 400 kHz post configuration? #334
- Only set reduced (80 kHz) I2C clock when talking to the atMega, which has a bit-banged implementation - For the rest of the chips, reset to to 200 kHz, which seems to provide max sampling on BNO while maintaining reliability
aacuevas
approved these changes
Oct 20, 2024
There was a problem hiding this comment.
The only weird interaction that I can see is that, when changing a miniscope parameter (e.g.: led brightness), the threading model could: Set I2C SCLHigh value, poll a BNO value, then set the SCLLow and perform other operations. However, this should not be an issue, it would be akin to clock stretching, which already happens.
It should be documentes, nonetheless, that polledBNO does not guarantee pure periodicity and that it might be affected even further by this sporadic parameter changes.
Apart for this specific thing, which we just need to be aware of, I think this is a good overall solution. I assume it was tested in hardware as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.