Fix RecordNode disk space check

open-ephys · Nov 29, 2023 · 15a66a6 · 15a66a6
1 parent cbcbd60
commit 15a66a6
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 7 deletions.
diff --git a/Source/Processors/ProcessorGraph/ProcessorGraphActions.cpp b/Source/Processors/ProcessorGraph/ProcessorGraphActions.cpp
@@ -84,10 +84,10 @@ bool AddProcessor::perform()
     {
         processor->parametersAsXml = settings;
         processor->loadFromXml();
-    }
 
-    if (processor != nullptr && !signalChainIsLoading)
-        processor->initialize(false);
+        if (processor != nullptr && !signalChainIsLoading)
+            processor->initialize(false);
+    }
 
     if (processor != nullptr)
     {
@@ -263,7 +263,7 @@ bool DeleteProcessor::undo()
     processor = processorGraph->createProcessor(description,
                                         sourceProcessor,
                                         destProcessor,
-                                        false);
+                                        true);
     processor->parametersAsXml = settings.get();
 
     if(processor->isMerger())

diff --git a/Source/Processors/RecordNode/RecordNode.cpp b/Source/Processors/RecordNode/RecordNode.cpp
@@ -75,7 +75,7 @@ RecordNode::RecordNode()
 
 	eventMonitor = new EventMonitor();
 
-	checkDiskSpace();
+	//checkDiskSpace();
 
 }
 
@@ -106,6 +106,12 @@ void RecordNode::registerParameters()
 	addSelectedStreamParameter(Parameter::PROCESSOR_SCOPE, "main_sync", "Main Sync Stream ID", "Use this stream as main sync", {}, 0, true);
 }
 
+void RecordNode::initialize(bool signalChainIsLoading)
+{
+	if (!signalChainIsLoading)
+		checkDiskSpace();
+}
+
 void RecordNode::parameterValueChanged(Parameter* p)
 {
 	if (p->getName() == "directory")
@@ -167,8 +173,14 @@ void RecordNode::checkDiskSpace()
 
 	if (availableBytes < diskSpaceWarningThreshold && !isRecording)
 	{
-		String msg = "Less than " + String(int(diskSpaceWarningThreshold)) + " GB of disk space available in " + String(dataDirectory.getFullPathName());
-		msg += ". Recording may fail. Please free up space or change the recording directory.";
+		String msg = "Record Node " + String(getNodeId());
+		msg += "\n\n";
+		msg += "Less than " + String(int(diskSpaceWarningThreshold)) + " GB of disk space available in:\n";
+		msg += "\n";
+		msg += "\t" + String(dataDirectory.getFullPathName());
+		msg += "\n\n";
+		msg += "Recording may fail. Please free up space or change the recording directory.";
+
 		AlertWindow::showMessageBoxAsync(AlertWindow::WarningIcon, "WARNING", msg);
 	}
 }

diff --git a/Source/Processors/RecordNode/RecordNode.h b/Source/Processors/RecordNode/RecordNode.h
@@ -92,6 +92,9 @@ class TESTABLE RecordNode :
 	/** Register parameters */
 	void registerParameters() override;
 
+	/** Initialize */
+	void initialize(bool signalChainIsLoading) override;
+
 	/** Respond to parameter value changes */
 	void parameterValueChanged(Parameter* p) override;