Ensure parameter enable state is copied

Fix crash when no input streams are available
open-ephys · Aug 30, 2023 · de9fc58 · de9fc58
1 parent 024691d
commit de9fc58
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/Source/Processors/Parameter/Parameter.h b/Source/Processors/Parameter/Parameter.h
@@ -144,7 +144,8 @@ class PLUGIN_API Parameter
         currentValue(other.currentValue),
         defaultValue(other.defaultValue),
         previousValue(other.previousValue),
-        m_deactivateDuringAcquisition(other.m_deactivateDuringAcquisition)
+        m_deactivateDuringAcquisition(other.m_deactivateDuringAcquisition),
+        isEnabledFlag(other.isEnabledFlag)
     {
         parameterListeners.clear();
     }

diff --git a/Source/Processors/Parameter/ParameterEditor.h b/Source/Processors/Parameter/ParameterEditor.h
@@ -94,16 +94,18 @@ class PLUGIN_API ParameterEditor : public Component,
     virtual void updateView() = 0;
 
     /** Sets the parameter corresponding to this editor*/
-    void setParameter(Parameter* param_)
+    void setParameter(Parameter* newParam)
     {
         if(param != nullptr)
             param->removeListener(this);
 
-        if(param_ != nullptr)
-            param_->addListener(this);
+        if(newParam != nullptr)
+        {
+            newParam->addListener(this);
+            setEnabled(newParam->isEnabled());
+        }
 
-        param = param_;
-        setEnabled(param->isEnabled());
+        param = newParam;
         updateView();
     }