-
Notifications
You must be signed in to change notification settings - Fork 13
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: add "/" op and fix special cases in schema (#122)
After @thisthat noticed I was missing "/", I added a test that with a massive targeting rule that doesn't make sense in terms of feature flagging, but uses every single default JSON logic op in their various forms. In doing that I found a missed a few special cases: missing special cases: "+" can be used with a single param to cast to number "-" can be used with a single param to multiply by -1 "substr" can be used with 3 args to to return a "middle" substring bugs: "reduce" needs 3 args "max/min" take an array directly and no mapper function, so they can take any amount of args "<" and "<=" require at least 2 args Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
- Loading branch information
Showing
9 changed files
with
239 additions
and
122 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
{ | ||
"$schema": "../../flagd-definitions.json", | ||
"flags": { | ||
"myBoolFlag": { | ||
"state": "ENABLED", | ||
|
Oops, something went wrong.