feat!: improve naming, fix module url #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beeme1mr
reviewed
Jan 17, 2024
The public URL will be more sensible, and a 1-line breaking change will need to be absorbed in flagd (where the schema is loaded). |
|
|
||
| //go:embed targeting.json | ||
| var Targeting string | ||
| var TargetingSchema string |
There was a problem hiding this comment.
We should track and change flagd references - https://github.com/open-feature/flagd/blob/main/core/pkg/evaluator/json.go#L407-L414
There was a problem hiding this comment.
Yes I am going to immediately absorb this in flagd when this is merged, since I want the better schema name.
Kavindu-Dodan
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Left this comment but otherwise I think this is good change
toddbaert
force-pushed
the
feat!/rename-base-schema
branch
from
93f5703 to
3ffb3aa
Compare
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
commented
Jan 18, 2024
| ``` |
There was a problem hiding this comment.
Now this file suggests reviewing the schemastore version, and updating the version hosted at flagd.dev
beeme1mr
approved these changes
Jan 18, 2024
Merged
toddbaert
pushed a commit
that referenced
this pull request
Jan 18, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>json/json-schema: 0.2.0</summary> ## [0.2.0](json/json-schema-v0.1.3...json/json-schema-v0.2.0) (2024-01-18) ### ⚠ BREAKING CHANGES * improve naming, fix module url ([#128](#128)) ### 🐛 Bug Fixes * "if" json schema description ([#126](#126)) ([eee6a28](eee6a28)) ### ✨ New Features * improve naming, fix module url ([#128](#128)) ([0e6cbbd](0e6cbbd)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
toddbaert
added a commit
to open-feature/flagd
that referenced
this pull request
Jan 19, 2024
Absorbs new schema, and go module changes from: open-feature/flagd-schemas#128 Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flags.jsoninstead offlagd_definitions$evalutorsthey are optional and used inflags.Fixes: #125