fix: support "if" 1-arg shorthand #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
commented
Feb 14, 2024
| @@ -0,0 +1,70 @@ | |||
| { | |||
There was a problem hiding this comment.
All of these didn't validate before this change, and now they do.
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
commented
Feb 14, 2024
| @@ -97,6 +97,22 @@ type: object | |||
| - type: array | |||
| items: | |||
| type: string | |||
| ifRule: | |||
There was a problem hiding this comment.
With this change, "if" can no longer share the its anatomy with other ops (binaryOrTernaryOp), since it's the only one that takes 1-3 args, so it's implemented as it's own rule now.
toddbaert
commented
Feb 14, 2024
| @@ -133,6 +133,22 @@ | |||
| } | |||
| } | |||
| }, | |||
| "ifRule": { | |||
There was a problem hiding this comment.
FYI @austindrenski , the JSON is generated from the YAML, and the CI makes sure they are in sync.
Kavindu-Dodan
approved these changes
Feb 14, 2024
beeme1mr
approved these changes
Feb 14, 2024
Merged
toddbaert
pushed a commit
that referenced
this pull request
Feb 14, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>json/json-schema: 0.2.1</summary> ## [0.2.1](json/json-schema-v0.2.0...json/json-schema-v0.2.1) (2024-02-14) ### 🐛 Bug Fixes * support "if" 1-arg shorthand ([#131](#131)) ([463d33a](463d33a)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
toddbaert
added a commit
to open-feature/flagd
that referenced
this pull request
Feb 20, 2024
Updates schema to include open-feature/flagd-schemas#131. Fixes: #1205 @austindrenski I imagine this is cached quite heavily by IDEs, etc. Not sure how long it will take to clear. Preview link: https://deploy-preview-1215--polite-licorice-3db33c.netlify.app/schema/v0/targeting.json Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds schema-support for 1-arg "if" shorthand.
Part of fixing: open-feature/flagd#1205