feat: fully version schema #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
commented
May 27, 2024
Comment on lines
+80
to
+90
| make gen-schema-json | ||
| if [ ! -z "$(git status --porcelain)" ]; then | ||
| echo "JSON schema generation produced diff, regenerating and committing result..."; | ||
| git config --global user.name "validate-and-sync-schema-job" | ||
| git config --global user.email "bot@openfeature.dev" | ||
| git add json/*.json | ||
| git commit -m 'chore: sync json schema from yaml' -s | ||
| git push | ||
| else | ||
| echo "No delta between YAML and JSON schemas, finishing..." | ||
| fi |
There was a problem hiding this comment.
If there is a diff, this regenerates the JSON from the YAML, and commits is back - this way when release please updates the YAML files based on the x-release-please comment, it regenerates the JSON files to match. I tested it out here.
Kavindu-Dodan
approved these changes
May 27, 2024
Merged
toddbaert
pushed a commit
that referenced
this pull request
May 27, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>json/json-schema: 0.2.6</summary> ## [0.2.6](json/json-schema-v0.2.5...json/json-schema-v0.2.6) (2024-05-27) ### ✨ New Features * fully version schema ([#163](#163)) ([c0692e4](c0692e4)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: validate-and-sync-schema-job <bot@openfeature.dev> Co-authored-by: validate-and-sync-schema-job <bot@openfeature.dev>
toddbaert
added a commit
that referenced
this pull request
Jun 17, 2024
Reverts #163. Though there's a lot of benefits, the maintenance burden here is too high. It means we will need to update the schema version everywhere, frequently. For example, we'd have to update it in places like this: https://github.com/open-feature/java-sdk-contrib/blob/ae21165c2bd65cad325e66e8373fe38da8a98baf/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/model/FlagParser.java#L46-L47 . I think this will be too error prone and too much of a maintenance burden for little benefit. I'm reverting back to only major version-based versioning. Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
$idnow has a full version string in it, like:https://flagd.dev/schema/v0.2.5/flags.json)Next steps will be to: